anotherproksy / ez-window Goto Github PK

Prepare README.md for release

• Variable naming
• Blank spaces
• Inline function documentation
  etc.

• Add global variable for "Resize Mode"
• Add global variable for "Open Terminal"

• Create doc/ directory
• Create ez-window.txt and add to doc/
• Add tags to doc/ and root

Issue Summary

If you close terminal buffer with :q or other commands, then next <C-t> execution will failed:

Error detected while processing function <SNR>38_NewTerminal:
line 3:

function! s:NewTerminal()
  if has('nvim')
    if exists('t:terminal_buffer')
      exe "bd! " . t:terminal_buffer " <-----
      unlet t:terminal_buffer
    else
      botright split
      resize 10
      terminal
      let t:terminal_buffer = bufnr()
      normal i
    endif
  else
    echo "Sorry, you are not a 'NeoVim' user ;("
  endif
endfunction

Steps to Reproduce

1. Create new terminal split <C-t>
2. Hit <C-\><C-n> to quit terminal insert mode
3. Close terminal split with any commands
4. Hit <C-t> again

Expected Results

It will create new terminal split.

Actual Results

It will throw an error message.

Workaround

Check if buffer exists, before closing it.

If you use <C-hjkl> to navigate Tmux splits, then you might stuck inside Vim pane.
<C-hjkl> inside Vim will create new splits, instead of navigating to different terminals.

Need to implement global variable to disable split creation inside function and set different mappings for this behaviour:

function! s:EzWindow(key)
  let t:curwin = winnr()
  exec "wincmd " . a:key
  if (t:curwin == winnr())
    if (match(a:key,'[jk]'))
      wincmd v
    else
      wincmd s
    endif
    exec "wincmd " . a:key | enew
  endif
endfunction

Issue Summary

If you create a few splits after hitting <C-t> (create new terminal bottom split), the next shortcut execution will close different split, instead of terminal.

Steps to Reproduce

1. Create new terminal split <C-t>
2. Hit <C-\><C-n> to quit terminal insert mode
3. Create new empty split
4. Hit <C-t> again

Expected Results

It will close terminal split.

Actual Results

It will close different split, instead of terminal one.

Workaround

This feature uses winnr() function, which saves current split ID number.
ID number changes after each :split command.
This implementation must be changed:

if exists('t:terminal_buffer')
    exe t:terminal_buffer . "wincmd c"
    unlet t:terminal_buffer
else
    botright split
    let t:terminal_buffer = winnr()
    resize 10
    terminal
    normal i
endif