anitaa1990 / trailersapp Goto Github PK

Can you please make detail post on medium(or anywhere ) on this project. Because it is too difficult to understand the code and follow the things that you have used. This is a masterpiece of code and I definitely want to learn it.

HI @anitaa1990 Great work! may I know how would you handle the the Network Error in UI ?
.doOnError(t -> onFetchFailed()) in NetworkBoundResource.java
I'm basing my code on same approach but limited understanding i have of it. I cant see how to inform UI of the network error? can you help me out with this ? i couldn't find a solution in your repository.
thanks .

Hi Anita,
I tried to run a code coverage report with your code. I am getting an error as follows

com.an.trailers.api.ApiAbstract > initializationError FAILED
java.lang.Exception

Any Ideas

Display Pendulum Swing Loop

I dont know what is wrong.

Hi! Thanks for the code sharing!
I have found you are not showing data fetched from local DB while the remote request is running:

    moviesListViewModel.getMoviesLiveData().observe(this, resource -> {
        if(resource.isLoading()) {
            //updateMoviesList(resource.data); - SHOULD BE HERE!
        } else if(!resource.data.isEmpty()) {
            updateMoviesList(resource.data);

        } else handleErrorResponse();
    });

What is the reason for such approach?

P.S.: Another point is you should not check resource.data.isEmpty() before updateMoviesList because of all movies can be removed from a remote server, but you will still have them on a local device screen