angro-kft / nav-connector Goto Github PK

A function should be added to test connection, technicalUser and softwareData validity.
This should be a tokenExchange operation. It throws if connection, technicalUser or softwareData is invalid but an additional testing should be done on the exchange key.
The exchange key length should be 16 character and the returned token should match the [0-9A-Za-z][-] pattern.

Az alábbi hibát írja teszt futtatás után:

1. queryInvoiceStatus()
   "before all" hook: before:
   Error: An invoice is still under processing!
   at retry (test/lib/wait-invoice-processing.js:81:15)
   at
   at process._tickCallback (internal/process/next_tick.js:188:7)

A NAV felületén pedig ezt írja gondnak:

A megadott számlaszám egynél többször szerepel a kérésben

• Field [productCodes] contains error: [Invalid content was found starting with element 'productCodes'. One of '{"http://schemas.nav.gov.hu/OSA/1.0/data":lineNumber}' is expected.]

The NavConnector constructor should assign the argument object's properties to the instantiation.
The constructor should also do basic validation on the technicalUser argument.

• remove unused eventEmitter class inheritance
• add public methods to NavConnector class
• add public api documentation
• remove unused dependency (cross-env)
• remove unused index.js file
• remove unused validation functionality

The sendRequest method normalizes error responses and renames schemaValidationMessages property to technicalValidationMessages to match documentation. After NAV service version 0.14 this functionality will be unnecesery because schemaValidationMessages will be technicalValidationMessages by default in the error response.

The module entry point should be en event emitter subclass which exposes public APIs and emits error and other events.

• editor config
• git
• npm
• eslint
• babel
• test framework (mocha)
• code coverage (Istanbul)
• continuous integration (CircleCi)
• add codecov

The default timeout is 60 sec but the NAV service closes the connection after 60 sec (gateway timeout 504).
The default timeout should be increased to give a chance to the service to close the connection before force close it.

• add queryInvoiceData operation
• fix response error handling
• add compressedContent to ManageInvoiceRequest

• add wip warning
• add maintainers
• add licence
• add NAV api specification link

The request xml schema has sequential element order requirement. The softwareData object key order must be normalized before creating the request xml.

add a validation function which can validate software data with a predefined schema just like technical user validation

• type conversion
• normalize technicalValidationMessages to array
• normalize businessValidationMessages to array

The queryInvoiceStatus function returnOriginalRequest parameter does not work. The NAV service api does not return the originalRequest property in the response.

Could be a NAV api service upstream issue.

The NavConnector constructor parameters should be extended with a timeout property.
This should set the axios default timeout option to 5500 milliseconds by default but it should be configured.
This is required because during NAV service outages, requests will never timeout if axios timeout option is not set.
The default 5500 milliseconds are sufficient because according to the NAV online invoice service documentation the request timeout is set to 5000 ms on the service side.

• local tests
• ci tests

The manageInvoiceRequest invoiceOperations param objects key orders must be normalized.

login pattern [a-zA-Z0-9]{6,15} should be ^[a-zA-Z0-9]{6,15}$
taxNumber pattern [0-9]{8} should be ^[0-9]{8}$

This pattern validation is incorrect in the specification.

• @param {Object} params.transactionId Manage invoice operation transaction id.

should be

• @param {string} params.transactionId Manage invoice operation transaction id.

hello ewol123,
Is nav-connector ready to work with XSD 2.0?
Is branch nav2.0 functional?
Thank you and best regards