andysuen / y2bdoublesubs Goto Github PK

Expected Behavior

Display two language subtitle.

Current Behavior

Subtitle is invisible.

console.log error:

error location: line 59

localeJson.events[i].segs[0].utf8 = line + '\n' + localeJson.events[i].segs[0].utf8;

Context (Environment)

• macOS Safari v14.1.1
• Tampermonkey v4.11.6117
• Y2BDoubleSubs/hook_request.js v1.6.2

Solution

When making a request for a subtitle (e.g. automatic generated english subs), the first event of response.json.events has no segs key.

"events": [
        { "tStartMs": 0, "dDurationMs": 1279979, "id": 1, "wpWinPosId": 1, "wsWinStyleId": 1 },
        { "tStartMs": 1409, "dDurationMs": 8470, "wWinId": 1, "segs": [ { "utf8": "you", "acAsrConf": 252 }

So, add a line below before accessing json.events[i].segs[0] will fix it.

if (!localeJson.events[i].segs) continue

Steps to Reproduce

Visit https://www.youtube.com/watch?v=Y8koAgkBEnM and play with CC on.

Display two language subtitle.