andyet / eslint-config-andyet-react Goto Github PK

This does a pretty good job of explaining why this rule exists and should arguably be used: https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-no-bind.md#lists-of-items

The problem I've found is that its quite cumbersome to create a new class in order to not use an arrow fn, especially if you list item is very simple. I've never seen the performance implications of this either, so it feels a bit like premature optimization, but I have no data either way. It seems like a good rule in theory, which is why I added it originally, but I've found myself working around it multiple times now in ways I wish I didn't have to.

"react/forbid-prop-types": [2, {"forbid": ["any", "array", "object"]}]

The docs explain it pretty well but the gist is that array and object prop types are ambiguous because they can contain values of any type so it kind of defeats the purpose of using prop types.

If we use this rule to forbid them, then arrayOf and shape can be used instead to provide more detail into what exactly is being passed to a component.

Is there a particular type of function style (declaration, express, arrow, etc) that we want to use consistently? http://eslint.org/docs/rules/func-style

• Possibly discuss #1 and #2
• Test on more repos that @latentflip had in mind
• Use those repos to iterate on any rules
• Publish