Git Product home page Git Product logo

shareabouts-wp's People

Stargazers

 avatar

Watchers

 avatar  avatar

shareabouts-wp's Issues

Default to "sign up"

The "sign in/up" modal should default to the "Create an account" form, as it's less likely folks will already have an account. And if they do, there's a big chance they're already signed in. So the "Sign in" form should be the less accessible of the two forms.

smoothState breaks WP Admin bar

When pages are loaded with smoothState.load(), the WordPress Admin Bar does not update. So links to e.g. "Edit Page" do not behave as expected.

Submit not bound to AJAX #place-submission-form

The place form works when its page is loaded directly. But if you arrive at page-add_shareabouts_place.php through a smoothState.load(), the submit is not bound โ€” doesn't prevent the default form method.

Bad redirect on place comments

When you leave a comment on single-shareabouts_place.php (or page-map.php), the comment works, but the URL changes to /wp-comments-post.php/. Commenting on regular posts works fine.

Place Submit LatLng not validated

The #place-submission-form can be submitted with any text in the #place-submission-location field. This breaks adding it to the map on success. This field is required. However, making it readonly or disabled prevents it from triggering client-side validation. We should manually check if this field is a LatLng (array of 2 numbers) and prevent form submission if not.

Try adding display:none with an error message: "Drag the map to your location."
^ This message is used in openplans/shareabouts for prevent users for submitting places without having dragged the map.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.