Git Product home page Git Product logo

Comments (7)

mochadwi avatar mochadwi commented on May 23, 2024 4

Sure, I get that naming is hard and each layer can have its own models, but what other entities are being referred to as being part of the domain layer? I see that it includes UseCases, Entities, and Repositories, so I'm trying to find out if there's some concept I'm missing.

EDIT: I did more searching and found this on the older, non-kotlin clean repo, so perhaps this answers my question. It does seem to me, however, that since the goal of this project is education, perhaps the naming conventions could be more clear? Perhaps MovieEntity could be MovieData denoting the data layer, the domain could have the canonical Movie or MovieEntity and the presentation layer could be MovieView? I'm just spitballing, but I'm trying to advocate for adopting clean and I'd like to head off any confusion if and when I have to explain these concepts to others.

Like stated here and detail explanation here for the difference. Solely, it's just naming but this convention make us a little easier to understand the architecture in the first impressions

from android-cleanarchitecture-kotlin.

carterhudson avatar carterhudson commented on May 23, 2024 3

Sure, I get that naming is hard and each layer can have its own models, but what other entities are being referred to as being part of the domain layer? I see that it includes UseCases, Entities, and Repositories, so I'm trying to find out if there's some concept I'm missing.

EDIT: I did more searching and found this on the older, non-kotlin clean repo, so perhaps this answers my question. It does seem to me, however, that since the goal of this project is education, perhaps the naming conventions could be more clear? Perhaps MovieEntity could be MovieData denoting the data layer, the domain could have the canonical Movie or MovieEntity and the presentation layer could be MovieView? I'm just spitballing, but I'm trying to advocate for adopting clean and I'd like to head off any confusion if and when I have to explain these concepts to others.

from android-cleanarchitecture-kotlin.

android10 avatar android10 commented on May 23, 2024

Movie = Domain
MovieEntity = DataLayer

from android-cleanarchitecture-kotlin.

carterhudson avatar carterhudson commented on May 23, 2024

Is it the case that the "entities" or "domain" layer is the innermost ring, yet data structures are suffixed with "entity" in the data layer? If so, that seems confusing. Maybe I'm misunderstanding something?

from android-cleanarchitecture-kotlin.

 avatar commented on May 23, 2024

@carterhudson "Naming is hard" ))

Each layer can have its own models.

from android-cleanarchitecture-kotlin.

jaychang0917 avatar jaychang0917 commented on May 23, 2024

IMHO, the current naming conventions is well-known in software engineering field. For example, Room uses Entity annotation to annotate a class as a db entity.

However, I am confused by the MovieView, it makes me think it is an android View but a model in presentation layer.

from android-cleanarchitecture-kotlin.

carterhudson avatar carterhudson commented on May 23, 2024

I think both of those conventions are well-known in-general, but when you put it in the context of Clean and accompany it with graphics and illustrations of layers that are named differently, terms start to be conflated.

from android-cleanarchitecture-kotlin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.