Git Product home page Git Product logo

Comments (10)

ruiperes avatar ruiperes commented on June 8, 2024 1

Something like this

`

class GetAllMovieDetails
@Inject constructor(private val moviesRepository: MoviesRepository) : UseCase<List, Params>() {
override suspend fun run(params: None) : Either<Failure, List> {

    val movies = MoviesRepository.movies()

    return movies.map {
        moviesRepository.movieDetails(it.id)
    }
} 

`

from android-cleanarchitecture-kotlin.

dashika avatar dashika commented on June 8, 2024 1

Many thanks, @ruiperes you save my ass =)

from android-cleanarchitecture-kotlin.

ruiperes avatar ruiperes commented on June 8, 2024

Don't put api calls on usecase. Is responsibility of the repository handle that.

from android-cleanarchitecture-kotlin.

dashika avatar dashika commented on June 8, 2024

But how if the method run only one?

override suspend fun run(params: None)

from android-cleanarchitecture-kotlin.

ruiperes avatar ruiperes commented on June 8, 2024

Can provide some code?

from android-cleanarchitecture-kotlin.

dashika avatar dashika commented on June 8, 2024
class GetMovies
@Inject constructor(private val moviesRepository: MoviesRepository) : UseCase<List<Movie>, None>() {

    override suspend fun run(params: None) = moviesRepository.movies()
}
class GetMovieDetails
@Inject constructor(private val moviesRepository: MoviesRepository) : UseCase<MovieDetails, Params>() {

    override suspend fun run(params: Params) = moviesRepository.movieDetails(params.id)

    data class Params(val id: Int)
}

I want to merge these 2 classes to 1, to have options get movie and their detail from one VM :

  1. https://github.com/android10/Android-CleanArchitecture-Kotlin/blob/master/app/src/main/kotlin/com/fernandocejas/sample/features/movies/GetMovies.kt

  2. https://github.com/android10/Android-CleanArchitecture-Kotlin/blob/master/app/src/main/kotlin/com/fernandocejas/sample/features/movies/GetMovieDetails.kt

from android-cleanarchitecture-kotlin.

ruiperes avatar ruiperes commented on June 8, 2024

Why don't use the GetMoviesUseCase and change the repository to return a list of MovieDetails? Or create a new use case when first get the list of movies and next get the details of the movies.

from android-cleanarchitecture-kotlin.

dashika avatar dashika commented on June 8, 2024

Could you please provide me sample code of GetMoviesUseCase , because I'm in confuse with
https://github.com/android10/Android-CleanArchitecture-Kotlin/blob/master/app/src/main/kotlin/com/fernandocejas/sample/core/interactor/UseCase.kt

from android-cleanarchitecture-kotlin.

ruiperes avatar ruiperes commented on June 8, 2024

Many thanks, @ruiperes you save my ass =)

No problem

from android-cleanarchitecture-kotlin.

Zhuinden avatar Zhuinden commented on June 8, 2024

I'd just delete BaseUseCase class, you don't really need it tbh

from android-cleanarchitecture-kotlin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.