Git Product home page Git Product logo

medusa-plugin-variant-images's People

Contributors

andriinuts avatar genox avatar microcloudcode avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar

medusa-plugin-variant-images's Issues

Expand variant Images

I enabled the product categories plugin and as I understand it, in order to show the product categories when viewing a product, I need to expand the categories field. Doing so, unfortunately, removed all the relational data (like images, profiles, variants, etc) I was getting for free. I am now required to expand the product relations that I need like images, variants, etc. So I did the following:

await medusa.products.list({ expand: "categories,images,profiles,variants,variants.options,variants.prices,variants.images", })

I get an error message that includes
data: { type: 'invalid_data', message: 'Relations [variants.images] are not valid' }

How do you expand the variant images field? Please help.

I am running medusa 1.15.1

[bug] update product api failed

I'm using admin api https://docs.medusajs.com/api/admin#products_postproductsproduct to update variant price.
The request body is like
{ "variants": [ { "id": "variant_01GDD33EDC4BK8065K0VXB5KJ1", "prices": [ { "id": "ma_01GDD33EDKFRRGX8TVGRYMQX58", "amount": 33408, "currency_code": "usd" } ] } ] }
After I updated the plugin to version 1.0.5, the api request failed.
image
I debugged the code, and found the update object is null. I think it's a previous version bug.

Updating variant images from a batch job / import strategy

I made a PR #11 just now, please have a look when you have the time.

Additionally, I made a few observations while trying to get a batch job working. But updating works for now.

What I am not sure about yet is how this acts when a variant is created while importing, but in this case, the import can simply be run twice for images to be attached.

Another issue that I have is that imported images can't be removed from a variant in the UI. They are not listed in the modal. But since I rely primarily on imports to populate data and the source of truth is elsewhere, this is good enough for me.

Sorry, this is incorrect. Images can't be removed I think. But they are not listed

I previously added images using a script using the admin js client and while it successfully added images (it simply added .images, no other data was changed, I assume that would have caused me to look into why other properties were not changed earlier), the images were not visible in the modal.

How to use this plugin?

image
image

How to use this plugin? I've installed the required dependencies and configured it in medusa-config.js, but the admin interface doesn't seem to have changed.

Image input is not showing

The plugin seems not able to work with the current version, what can I do on my side?

  "dependencies": {
    "@medusajs/admin": "7.1.9",
    "@medusajs/cache-inmemory": "^1.8.9",
    "@medusajs/cache-redis": "^1.8.9",
    "@medusajs/event-bus-local": "^1.9.7",
    "@medusajs/event-bus-redis": "^1.8.10",
    "@medusajs/file-local": "^1.0.2",
    "@medusajs/medusa": "1.19.0",
    "@tanstack/react-query": "4.22.0",
    "body-parser": "^1.19.0",
    "cors": "^2.8.5",
    "dotenv": "16.3.1",
    "express": "^4.17.2",
    "medusa-file-s3": "^1.4.0",
    "medusa-fulfillment-manual": "^1.1.38",
    "medusa-interfaces": "^1.3.7",
    "medusa-payment-manual": "^1.0.24",
    "medusa-payment-stripe": "^6.0.5",
    "medusa-plugin-variant-images": "^1.0.4",
    "prism-react-renderer": "^2.0.4",
    "typeorm": "^0.3.16"
  }

Variant thumbnails/images not visible

Here are the library versions I am using

    "@medusajs/admin": "7.1.11",
    "@medusajs/medusa": "1.20.2",
    "@tanstack/react-query": "4.22.0",
    "body-parser": "^1.19.0",
    "cors": "^2.8.5",
    "dotenv": "16.3.1",
    "express": "^4.17.2",
    "medusa-file-azure-blob": "^1.0.2",
    "medusa-fulfillment-manual": "^1.1.39",
    "medusa-interfaces": "^1.3.8",
    "medusa-payment-manual": "^1.0.24",
    "medusa-payment-stripe": "^6.0.7",
    "medusa-plugin-variant-images": "^1.0.5",```

I followed the entire plugion guide and the migrations ran succesfully ( I can see the columns created )

but I dont see the image upload options in UI

Error when clicking the any of the products in the products section in the Admin App

Hello! I'm currently having an issue where I couldn't access the product edit page on the admin dashboard due to an error. When I removed the plugin in the config, it worked again. Would there be a fix for this? Thank you!

Also to help, I've also extended the product variant entity with custom relations in the modules folder. I'm not sure if this will disrupt the flow of the plugin.

Screenshot 2023-10-21 at 1 34 28 PM

feature requests: removal of images, reordering

Hi,

Thanks for sharing this plugin. This should be part of core IMHO.

To further improve it, why not allow the user to

a) remove an image from a variant (similar to how a product image can be removed)
b) reorder variant images so that their order is reflected in the variant images array served by the API

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.