andrewx192 / lenovo-sa120-fanspeed-utility Goto Github PK

I just wanted to say how great this is!!! Thanks for making life easy, man Open Source is just great

When #5 "Allows script to set fan speed on multiple enclosures" was merged in it broke the script with mixed tabs and spaces.

As-is it no longer works.

Hooked one up to a proxmox box. All drives pop right in, but the script continually doesn't find the enclosure. these fans are driving me nuts.

Using CentOS 7, the script was not able to find my SA120. It would appear that the sg_ses command does not support the flag "--maxlen=32768". After removing this argument from the script, it works just fine.

if len(sys.argv) < 1:
    print("python fancontrol.py 1-7")
    sys.exit(-1)

fan = int(sys.argv[1])

if fan <= 0 or fan > 6:
    raise Exception("Fan speed must be between 1 and 7")

1. len(sys.argv) < 1 will never happen because sys.argv[0] is always the name of the file

2. if fan <= 0 or fan > 6 to get 1-7?? if fan < 1 or fan > 7 -- as-is picking 7 breaks script

            print("Enclosure found on " + device);

3. there are no semi-colon endings in python

I don't have any hardware error lights on, but the script always says Fan 3 is at 0 RPM. Which specific fan is that? I may try to replace one or all the fans, but I'm trying to narrow down which one might have failed.