andrewthe13th / inventory_kamera Goto Github PK

I changed the display mode to 1280x720 windowed and the scanning worked fine for weapons and artifacts.
When scanning the characters, it works for a few but then randomly opens the details page and gets stucked resulting in an error.
It happen on any random character in random order.

With 0.8 weapons and artifacts are not counted correct anymore?

the issue:
https://photos.app.goo.gl/rs3VkeBi2YTefLYR9

Your program worked fine 2 days ago, but after I deleted some weapons this bug happens. The program cant stop scanning by itself so I have to stop it by pressing ctrl + alt + del

I cant see any export files after finishing the scan

scanned all my chars but only 3 arti equipped for each chars.

Thanks for the program, really enjoying it.

Was running into issues scanning all of my characters, I think it was because after I changed my resolution I moved the program slightly, as after restarting Genshin and leaving it in place, it scanned everything perfectly

Other than the small issue with character scans this was the only other error I came across -
Error: Error: prayerstospringtime is not a valid Set Name

As the title says, the scanner might fail to scan inventory and spit out an empty json file if you bound the "Open Inventory" key to anything else but "b"

If you reset your keybinds to default, everything works fine.

So this is in regards to those that have their scanner crashing on them while scanning. I've been trying to debug this problem for awhile now and seemed to have finally found the culprit behind the crashing.
Note: this likely only applies to those that have monitors that are not in the 16;9 ratio, like my ultrawide monitor that is in 21:9.
Note2: I use the term 'compressed' and 'uncompressed' here, but it's likely not the right term, hopefully you get the idea..

The problem:

• On an ultrawide screen (unsure if specific to ultrawide), the UI is slightly compressed for easier access.
• If you've been playing the game in ultrawide resolution, then the game will compress the UI for you.
• Going from ultrawide to the standard 16:9 resolution doesn't change the UI from compressed to uncompressed (see examples below).
• Thus, when you use the scanner, it assumes that the UI is in the uncompressed state which then leads to the scanner crashing.

The fix:

• First set your game to the desired 1280x720 any acceptable non-ultrawide resolution then completely close the game.
• Now start the game back up again, the UI should be in the uncompressed state.
• The scanner should now work correctly and scan everything.

Example images below:

Wrong UI for scanning, the UI is compressed

Correct UI for scanning, the UI is not compressed

Version: v0.8

scanned image not start at the right offset.
i'm using ultra wide monitor with 2560 * 1080 resolution(the game is at 1280 * 720). not sure if it's the cause.

Whenever the scan goes to do artifacts, I get "Error: Couldn't find rarity for artifact" and it does not scan any artifacts. It did do weapons and characters still though.

Latest version (0.9), Vortex Vanquisher and Freedom-Sworn are not correctly parsed and throws errors.

Error log from the tool :

Error: Found instead of Weapon Level.
Error: mysticenhancementore is not a valid Weapon Name

Error log from Genshin Optimizer :

[
  {
    "key": "VortextVanquisher",
    "level": 50,
    "ascension": 3,
    "refinement": 1,
    "location": ""
  },
  {
    "key": "Freedom-Sworn",
    "level": 1,
    "ascension": 0,
    "refinement": 1,
    "location": "KaedeharaKazuha"
  }
]

It is possible to have over 1000 artifacts due to domain rewards. In my case I had 1003 which triggered the overflow condition in ScanArtifactCount which seemingly divides the value by 10. It is fixable by simply deleting some artifacts down below 1000 but an error message or warning would be a good idea.

I kept getting "Error: aanemodmgbonus is not a valid Main Stat Name"
I have 563 artifacts during the scans, but in 508th the program stops and closes
Tried it in 3 different Scanner Delays. Still has errors.
Not sure if there's something else I need to do before scanning for it to work properly

The Weapon and Character scans worked.

I ran into the same issue reported by chronospectrum while scanning artifacts. In some cases it even stopped scanning after the first 3 or 4 artifacts.

It started working correctly after i reduced the amount of artifacts in my inventory from 811 to 786.

Awesome app, great job. Just one issue, you've got listed "Aquil/i/a Favonia" in your list instead as "Aquila Favonia". As well as having issue to get chars listed correctly, I've got mainly issues with Sayu it seems, but I've read in previous posts that you're already working on that issue. Would be great to have check box next to chars/weapons/artefacts to re-run scans if one fails for something and try again only that one instead of getting again 1000 artefacts and 200 weapons, if only chars failed.
Thanks a lot for your great work, can't wait for next update <3

1. Pressing enter to stop doesn't work reliably
2. Click on 50ms for Scanner Delay doesn't work and can only be done by dragging. (Increasing size might fix)
3. Format selection should be a Radio Button

Feature Suggestions
Allow for importing character, weapon, and artifacts names and indexes from a JSON file so compatibility doesn't break for future versions without an update (Users can edit). A default list as a backup can still be kept and compiled into the program.

There seems to be an issue with scanning the first row in the weapons category.

Here's a video of the issue: https://youtu.be/mueiaGYr6UA

Here is the console output:
Error: Found instead of Weapon Level.
Error: mysticenhancementore is not a valid Weapon Name

When you own the Viridescent Venerer you get the error "Error: aanemodmgbonus is not a valid Main Stat Name" message and then after it scans your whole artifacts the application crash.

Behaviour: Application Skips weapons at random
How to replicate: unknown

Version 0.8 works as expected.

Version 0.9 successfully scans all weapons and characters, but the artifact process seems to fail around row 11. At that point, row 13 scrolls from just below view at the bottom all the way up to the top visible row. The scanner then tries to scan rows 13-17 (basically all onscreen artifacts) before concluding the scanning process and moving on to characters (if enabled). This issue happens to me at all 3 delay levels.

I do all the steps then I leave the game and its at the start game screen. I scan but nothing happens then the app crashes, idk what im doing wrong. If soemone could help me figure this out it would be much appreciated :).

The tessdata folder is not included in the repository. It appears to be only included in the release zips, which means I cannot use the program if I compile it myself -- it crashes after I start scanning.

Additionally, Windows Defender thinks the release zip contains a virus and deletes the file as soon as it's finished downloading. I had to download it using wget under WSL to discover that the tessdata folder is included in the zip.

There's no support for 16:10 resolutions, I have no option for 1280x700 since I'm using a 1440x900 monitor

The character menu opened and the scanner scanned traveller and then ended the scan.

Did a scan with v0.9 of scanner from game, and imported to GO. There are instances of duplicated artifacts in the scanned data.

You can see the snippet of the exported data here, where the duplicated artifact was scanned to be equipped on ganyu on both. The equipment linking is "fixed" when imported to GO(only one char can be equipped per slot).

Also instances of artifacts not scanned as well. Perhaps there are rows of artifacts in inventory that are scanned in duplicate, which are skipping other rows?

I would recommend a "verification" step at the end of the scan, you can easily check for duplications here. A duplicated artifact that are equipped to the same character would indicate an error, a duplicate artifact might indicate an warning(very rare)

{
      "setKey": "WanderersTroupe",
      "slotKey": "plume",
      "level": 20,
      "rarity": 5,
      "mainStatKey": "atk",
      "location": "Ganyu",
      "lock": true,
      "substats": [
        {
          "key": "critDMG_",
          "value": 14.8
        },
        {
          "key": "def_",
          "value": 13.9
        },
        {
          "key": "critRate_",
          "value": 11.3
        },
        {
          "key": "def",
          "value": 16.0
        }
      ]
    },
    {
      "setKey": "WanderersTroupe",
      "slotKey": "plume",
      "level": 20,
      "rarity": 5,
      "mainStatKey": "atk",
      "location": "Ganyu",
      "lock": true,
      "substats": [
        {
          "key": "critDMG_",
          "value": 14.8
        },
        {
          "key": "def_",
          "value": 13.9
        },
        {
          "key": "critRate_",
          "value": 11.3
        },
        {
          "key": "def",
          "value": 16.0
        }
      ]
    },
    ```

Genshin Optimizer (https://frzyc.github.io/genshin-optimizer/#/database) expects "TheViridescentHunt" as bow name, but exporter uses the name "TheViridescent"
GOOD data here: https://pastebin.com/3yGe62Tg

When scanning items equipped by the Travaler it gives these errors:

Error: Zotya is not a valid Character Name
Error: z is not a valid Character Name
Error: z is not a valid Character Name
Error: z is not a valid Character Name

(And also, in V0.8 in the changelog you mention that the lower level weapon and artifact scanning is off by default. Is there a way to enable it?)

Hey there, having a problem completing a scan. The app seems to finish checking everything but then crashes, this is what I see in the application event log. Genshin is the Epic version, not running on the C drive if that makes a difference. Tried running this a few times and from various locations inc the game directory.

Any help appreciated :)

.net runtime error

• 1026 0 2 0 0 0x80000000000000 83032 Application Computer
• Application: GenshinGuide.exe Framework Version: v4.0.30319 Description: The process was terminated due to an unhandled exception. Exception Info: System.IO.FileNotFoundException at System.IO.__Error.WinIOError(Int32, System.String) at System.IO.FileStream.Init(System.String, System.IO.FileMode, System.IO.FileAccess, Int32, Boolean, System.IO.FileShare, Int32, System.IO.FileOptions, SECURITY_ATTRIBUTES, System.String, Boolean, Boolean, Boolean) at System.IO.FileStream..ctor(System.String, System.IO.FileMode, System.IO.FileAccess, System.IO.FileShare, Int32, System.IO.FileOptions, System.String, Boolean, Boolean, Boolean) at System.IO.StreamWriter.CreateFile(System.String, Boolean, Boolean) at System.IO.StreamWriter..ctor(System.String, Boolean, System.Text.Encoding, Int32, Boolean) at System.IO.StreamWriter..ctor(System.String, Boolean) at GenshinGuide.Scraper.CreateJsonFile(GenshinGuide.GOOD) at GenshinGuide.Form1.b__8_0() at System.Threading.ThreadHelper.ThreadStart_Context(System.Object) at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean) at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean) at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object) at System.Threading.ThreadHelper.ThreadStart()

Then application error

• 1000 0 2 100 0 0x80000000000000 83033 Application Computer
• GenshinGuide.exe 1.0.0.0 b9c34461 KERNELBASE.dll 10.0.19041.1202 448a4f5d e0434352 0012b5b2 3364 01d7bec1e3758881 C:\Users\Username\Documents\Genshin_Scanner_V0.8\GenshinGuide.exe C:\WINDOWS\System32\KERNELBASE.dll bde2fd7f-042a-49d2-9909-331080e977bf

Whenever I try to scan my characters, the scanner will always stop at Tartaglia, regardless if there are any other characters to scan. If he is in my party, it will skip him altogether.

Previously, I had an error similar to "error: prayerstosea is not a valid Set Name" or something, I've been trying to get the error to appear again but it doesn't say anything anymore. I thought it had something to do with his artifacts, so I unequipped all of them, but it still won't work.

Update, before posting this issue I tried once again to see if I could get the error name right, but this time it worked... I have done literally nothing different, except this time, the traveler is the one who didn't get scanned. The error I got is the following:

"Error: Error: prayerstospringtime is not a valid Set Name"

Issues:

• When weapon and artifact scanning sometimes scrolling doesn't work and double scans the same item.
• Sometimes doesn't scan characters and just stops.
• Doesn't detect the Traveler name correctly. (Error Log: "Error: [Traveler] is not a valid Character Name")
• Pressing enter to stop sometimes doesn't work. / Blocks the ability to press enter in other applications when not scanning sometimes. (Most Likely due to KeyboardHook / KeyHandler)
  Feature Request:
• Togglable scanning of Weapon, Artifact, and Characters with a checkbox
• Check for doubled artifacts and weapons

I have much more of them, it does not include even all my lvl 20

Every time I try to scan the error "Game Window not set to 1280x720 Windowed" show up, even if the game is in that resolution. Tried restarting several times the game.

i get lot of erro:amenodamage is not a main state

app crach at 973/1002 (artefact only)

i have tray at 0m and 50ms

whene i did only artefact at begin scanne did't click on artefact tab and stuck at wep tab

Pretty sure I followed the guide step by step, but I will just walk thro my steps atleast

• Downloaded the 0.9 version
• Unziped it
• Startet the program and then launched genshin
• put the game in 1280x720 Windowed and Controler type Keyboard
• left the window in the paimon menu / esc menu
• click scann

wosh and it crashes and will constantly close it self. any ideas?

After following all the instructions, the game is on the "Start Game - Click to Begin" page. I click "Scan Genshin". The focus is switched to the Genshin window, the mouse is moved to a position near the top of the window (slightly to the left of center), then the app crashes.

The scanner seems to scan weapons fine, at least it goes through them. However, it cannot seem to swap between the weapons and artifacts pages so it ends up scanning the same page twice and erring.

Hi There,

I cannot seem to get the program to create a JSON file for output, it scans through fine however no file is created. Unless I am very dense and completely missed it.

I think this may be an issue with my player name "Shogun'sSimp" as I did get an error once "Shogun'sSimp is an invalid name" the name itself was a funny joke at the time and now I am stuck with it until we can change our names/sig again.

thoma is not in DB?

Version: v0.7
Settings: 1280x720 Windowed - English - Keyboard

• The program crash at the middle of artifacts scan.
• The OCR seems not working properly for weapons
  Error: Found instead of Weapon Level.
Error: AmOSBow is not a valid Weapon Name
Error: Found instead of Weapon Level.
Error: MistsplitterKetTorged is not a valid Weapon Name
• And when I press ENTER to stop the scanner, it throw an exception, don't know if it's the expected behavior.

1. 1280 windowed as instructed
2. No flux or filters active
3. Crashes after scanning 15-16 weapons (R3 serpent spine or R5 festering desire)

Please let me know any additional info you require

Once I scan and check the file, all weapons are listed as R1 weapons.

My weapon has 111, but the program read 11 and started scanning on the second row and then finished with 11 weapons.
manually fixed by consuming some 1 stars until 109 left and scan again, it works perfectly.

while scanning one of my characters therre was a miss input that caused the game to be, on this case in specific, to be stuck on fischl's atribute menu.

I currently have 811 artifacts and the system only picks up 81 or 11

First of all, thank you so much for creating such an amazing tool!

I'm using Windows 10 64-bit. The scanner used to work perfectly. I foolishly interrupted the scanning by force-closing the program (I didn't know to press Enter to stop it), and since then, it has been unable to scan weapons at all.

I have tried restarting my computer, and changing the directory to which the JSON is saved. I have tried wiping the program + its existing JSON files from my system and redownloading it, as well as downloading older versions. It still skips over weapons each time when beginning the scan. When I use the latest version and only tick "Weapons" to be scanned, I get a Windows error saying the scanner encountered an unexpected error and has to close:

Is there something else in my computer I can "clear" or reset to try and get it working again?

Thank you!

I currently unable to scan with the 0.9 version of the game. No clue on how.

How to reproduce

• Download a zip file from release
• Unzip a file
• Click "Run" when Windows Defender told me not to
• Click "allow" in user access control
• Go to the Genshin windows
• Setup the screen resolution
• Leave the Genshin windows using Paimon Menu opened
• Click "Scan Genshin" from the scanner

Information about the PC

• OS : Windows 10
• Resolution : 1280 x 720
• Graphics quality : Low (Default)
• Native screen resolution : 2K

This was the only issue I had when first trying this one out.

I'm using version 0.7, settings are

• Graphics: 1280x720 Windowed
• Language: English
• Control: Keyboard

The scanner scans every just fine, except for:

• Dark Iron Sword, which was reported in #4
• Sangonomiya Kokomi: give message "Error: Character Name and Element are wrong"
• Mona's Stellaris Phatasm and Ayaka's Kamisata Art: Soumetsu's level are incorrect. The scanner scan their Alternate Sprint skill's level (which is always 1) instead. Unlike other characters, their burst skills are at 4th place from the top, not 3rd.
  

Thank you for creating this tool and make it open source. Have a good day.

Error: ıronsting is not a valid Weapon Name
Error: crıtdmg is not a valid Sub Stat
Error: crıtrate is not a valid Sub Stat
Error: crıtrate is not a valid Main Stat Name
Error: crıtrate is not a valid Sub Stat

I get errors like this and most likely it is caused by the language my system is using which is Turkish. And in Turkish we have "ı" as well as "İ" so can you add support for those letters because reinstalling windows is a pain.