in _send_cmd method (check_zookeeper.py line 169)

-- data = s.recv(2048)

++ data = ''
++ while True:
++ pack = s.recv(2048)
++ if len(pack) is 0:
++ break
++ data += pack

I'm not very familiar with python, you may rewrite this for better reading / performance.

Thank you for your plugin~

Any way you could have something (a script?) that converts "stat" output (etc..., and provides defaults for metrics not available prior to 3.4) for users running older versions of ZK? It would really enable more people to try it out, granted with reduced metric coverage.

Hello.
When run script get error:

./check_zookeeper.py -o nagios -s localhost
Traceback (most recent call last):
File "./check_zookeeper.py", line 337, in
sys.exit(main())
File "./check_zookeeper.py", line 255, in main
cluster_stats = get_cluster_stats(opts.servers)
File "./check_zookeeper.py", line 290, in get_cluster_stats
for host, port in servers:
ValueError: need more than 1 value to unpack

But mntr work fine:

echo 'mntr' | nc localhost 2181

zk_version 3.4.11-37e277162d567b55a07d1755f0b31c32e93c01a0, built on 11/01/2017 18:06 GMT
zk_avg_latency 0
zk_max_latency 316
zk_min_latency 0
zk_packets_received 171365
zk_packets_sent 171364
zk_num_alive_connections 6
zk_outstanding_requests 0
zk_server_state standalone
zk_znode_count 18
zk_watch_count 2
zk_ephemerals_count 3
zk_approximate_data_size 633
zk_open_file_descriptor_count 33
zk_max_file_descriptor_count 4096

Shouldn't a missing key (eg because the host/service is down) result in an critical error?

*** check_zookeeper.py.orig 2013-02-15 15:31:48.417663551 +0100
--- check_zookeeper.py  2013-02-15 15:23:33.100174871 +0100
***************
*** 47,55 ****
--- 47,57 ----
              return 2
  
          warning_state, critical_state, values = [], [], []
+   key_found = (opts.key is None)
          for host, stats in cluster_stats.items():
              if opts.key in stats:
  
+       key_found = True
                  value = stats[opts.key]
                  values.append('%s=%s;%s;%s' % (host, value, warning, critical))
  
***************
*** 60,65 ****
--- 62,72 ----
                      critical_state.append(host)
  
          values = ' '.join(values)
+ 
+   if not key_found:
+             print 'Critical "%s" %s!|%s' % (opts.key, ', '.join(critical_state), values)
+             return 2
+ 
          if critical_state:
              print 'Critical "%s" %s!|%s' % (opts.key, ', '.join(critical_state), values)
              return 2

Hi,

thanks for sharing that test helper.

I guess it makes some sense not to fail hard when one server can't be reached. But on the machine level I think that should be a hard fault.
How can I make the nagios helper throw critical if the service is not reachable (only testing localhost on every machine in that case)
Is there a trick to do that or should I test differently?

Also, I'm no zookeeper expert. Does any of the metrics measured in https://github.com/andreisavu/zookeeper-monitoring/blob/master/nagios/services.cfg monitor something as generic as 'cluster status good/bad'?