Git Product home page Git Product logo

Comments (7)

hammoudbilal avatar hammoudbilal commented on July 20, 2024

yes I know why this issue appears, it is just that exponential solver still has pinocchio::aba() for integrating in the air here compare pinocchio::ComputeMInverse() here

from consim.

andreadelprete avatar andreadelprete commented on July 20, 2024

Maybe @jcarpent could help us with this. We are computing the forward dynamics with 3 different methods here. They should all give the same results, but they don't. For instance:

aba_chol_Minv

When I do the same in Python I get the same results, so clearly there's something wrong with the way we are using these methods in C++. Any idea what could be the problem?

from consim.

andreadelprete avatar andreadelprete commented on July 20, 2024

Thanks to the PR of @jcarpent now the Euler simulator gives consistent results when the robot is in the air. However, this is not the case for the ExponentialSimulator. Here some results:
figure_1
Basically it seems that everything works except for Exp-Cholesky. But Cholesky works fine in the Euler simulator.

Moreover, what's really weird is that if I replace this line in the code with this:

dvMean_.noalias() = data_->Minv*mDv_; 

(as it was done in the PR by @jcarpent ) and recompile, then I get different results also for Exp-ABA, which shouldn't be affected by this change:
figure_2
The line corresponding to Exp-ABA is a bit hard to spot, but it's basically overlapping with the one of Exp-Cholesky.

The only possible explanation I have for this is some memory issues. Any other idea?

from consim.

hammoudbilal avatar hammoudbilal commented on July 20, 2024

hi @andreadelprete ,
there was a minor bug here that i fixed, could you confirm that his fixes the issue you see with Exp-Cholesky ?

from consim.

andreadelprete avatar andreadelprete commented on July 20, 2024

I confirm that this solves the problem. However, I am still worried about the result I reported above, because I am afraid there might be some issues with the memory. I don't know how to proceed to try and find them though.

from consim.

jcarpent avatar jcarpent commented on July 20, 2024

Could we do a meeting to explain me in details the issue you have in mind?

from consim.

andreadelprete avatar andreadelprete commented on July 20, 2024

Let's close this issue for now

from consim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.