Git Product home page Git Product logo

lidl-plus's People

Contributors

1-byte avatar andre0512 avatar dakse avatar dependabot[bot] avatar vorostamas avatar woyken avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

lidl-plus's Issues

Suggestion: Dockerization

I would be most appreciative if an example in docs or in practical implementation would be shown on how to run code from the library inside a docker container (preferably with docker-compose).

When running it on a desktop computer seems no problem at all, I have spent an entire day on trying to dockerize the lib but I still didn't manage to run it on a ubuntu server.

Cannot get refresh-token

After adding .items() inside the _register_link function in lidlplus/api.py here:

kép

I was able to navigate to the page, but after providing the e-mail and password, then hitting the next button nothing happened:

kép

API change

Just letting you know that API version 1 became unavailable (at least here in NL), so I did some research, and here are the updated endpoints:

  • Ticket list
    Old: https://tickets.lidlplus.com/api/v1/NL/tickets/list
    New: https://tickets.lidlplus.com/api/v2/NL/tickets
    You can use the query parameter pageNumber to select the page of the paginated response, and onlyFavorite (true/false) to filter by favourite status.

  • Ticket details
    Old: https://tickets.lidlplus.com/api/v1/NL/tickets/{id}
    New: https://tickets.lidlplus.com/api/v2/NL/tickets/{id}

Response data structure also slightly changed, for example records in the list response is now tickets instead.

Also, methods for these aren't currently implemented in your library, but you might be interested in them:

  • Mark ticket (receipt) as favourite:
    POST https://tickets.lidlplus.com/api/v2/NL/tickets/favorite, with JSON body ["ticketidhere"]
  • Mark ticket (receipt) as not favourite:
    POST https://tickets.lidlplus.com/api/v2/NL/tickets/unfavorite, with JSON body ["ticketidhere"]
  • Coupon list: https://coupons.lidlplus.com/api/v2/NL
  • Coupon details: https://coupons.lidlplus.com/api/v2/NL/{id}
  • Coupon activation: POST (activate) or DELETE (deactivate) to https://coupons.lidlplus.com/api/v1/NL/{id}/activation

There's a bunch more endpoints for announcements, store details, shopping lists, etc, I'll document them all at some point, but hopefully the above will save you some trouble fixing the current methods in your library.

Set Favorite Market

Hi,

thanks for providing this nice package.
With feature #7 it's possible to automatically activate all coupons available to all markets. However, there may be coupons that are only available to the selected favorite market. In the app, this favorite market can be selected under settings.

Without setting a favorite market, the first part of the response of LidlPlusApi.coupons() looks like this: {'name': 'FavoriteStore', 'coupons': []}
To automatically enable the coupons for the favorite market as well, it would be nice to support the selection of the favorite market per API.

By the way, in case someone runs into the same problem:
Some LIDL coupon names are not UTF-8 compliant. This may lead to such an error when printing the coupon name:
UnicodeEncodeError: 'latin-1' codec can't encode character '\u20ac' in position 1120: ordinal not in range(256)
Therefore, it might be worth sanitizing the string before using it further. For me, the following encoding of the string worked:
coupon["title"].encode('utf8', 'ignore')

Unable to get refresh token with Firefox

Describe the bug
I'm not familiar with selenium at all, but lidl-plus auth was reporting that I don't have firefox installed (I do). Removing executable_path, firefox_binary and firefox_profile arguments from webdriver.Firefox() in _init_firefox() fixed this issue.

Expected behavior
I'm supposed to get a refresh token.

Environment (please complete the following information):

  • Python-Version: 3.11
  • Release-Version: 0.2.6
  • OS: Fedora 37
  • Browser: Firefox and Chromium
  • Country: CZ
  • Language: cs

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.