Git Product home page Git Product logo

sentry-comments's People

Contributors

andialbrecht avatar anh avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar avatar

Forkers

anh kleopatra999

sentry-comments's Issues

Add option to NOT send mail on comment form

Sometimes it would be good NOT to send out emails when posting a comment. For example when an issue came up on staging but is already resolved.

An checkbox "Send mail" should be visible on comment form. It's always enabled by default, but can be unchecked for single comments.

No Comment option showing up

I installed sentry-comments with pip install sentry-comments but, after restarting sentry through supervisor, I still don't see a comment option.

How can I debug this further?

Migration from 0.2.0 to 0.3.0 fails

I'm trying to upgrade a Sentry 6.3.2 instance with sentry-comments 0.2.0 to Sentry 6.4.4 with sentry-comments 0.3.0. When I run sentry upgrade, I get this error:

Performing upgrade before service startup...
Syncing...
Creating tables ...
The following content types are stale and need to be deleted:

    auth | user

Any objects related to these content types by a foreign key will also
be deleted. Are you sure you want to delete these content types?
If you're unsure, answer 'no'.

    Type 'yes' to continue, or 'no' to cancel: no 
Installing custom SQL ...
Installing indexes ...
Installed 0 object(s) from 0 fixture(s)
Migrating...
Running migrations for djcelery:
- Nothing to migrate.
 - Loading initial data for djcelery.
Installed 0 object(s) from 0 fixture(s)
Running migrations for django:
- Nothing to migrate.
 - Loading initial data for django.
Installed 0 object(s) from 0 fixture(s)
Running migrations for sentry:
 - Migrating forwards to 0108_fix_user.
 > sentry:0106_auto__del_searchtoken__del_unique_searchtoken_document_field_token__de
 > sentry:0107_expand_user
 > sentry:0108_fix_user
 - Loading initial data for sentry.
Installed 0 object(s) from 0 fixture(s)
Running migrations for nodestore:
 - Migrating forwards to 0001_initial.
 > nodestore:0001_initial
 - Loading initial data for nodestore.
Installed 0 object(s) from 0 fixture(s)
Running migrations for search:
 - Migrating forwards to 0001_initial.
 > search:0001_initial
 - Loading initial data for search.
Installed 0 object(s) from 0 fixture(s)
Running migrations for social_auth:
- Nothing to migrate.
 - Loading initial data for social_auth.
Installed 0 object(s) from 0 fixture(s)
Running migrations for sentry_comments:
 - Migrating forwards to 0001_initial.
 > sentry_comments:0001_initial
FATAL ERROR - The following SQL query failed: CREATE TABLE "sentry_comments_groupcomments" ("id" serial NOT NULL PRIMARY KEY, "group_id" integer NOT NULL, "author_id" integer NOT NULL, "message" text NOT NULL, "created" timestamp with time zone NOT NULL)
The error was: relation "sentry_comments_groupcomments" already exists

Error in migration: sentry_comments:0001_initial
DatabaseError: relation "sentry_comments_groupcomments" already exists

Database installations seems to be failing

Hi,

I just upgraded to sentry 6.0.6 and installed your plugin. After upgrading the database (sentry upgrade) and restarting sentry, your plugin is visible in the projects and enabled, but in the logs I see the following error:

Error processing 'actions' on 'CommentsPlugin': (1146, "Table 'sentry.sentry_comments_groupcomments' doesn't exist")
Traceback (most recent call last):
  File "/var/sentry/sentryenv/lib/python2.6/site-packages/sentry/utils/safe.py", line 19, in safe_execute
    result = func(*args, **kwargs)
  File "/var/sentry/sentryenv/lib/python2.6/site-packages/sentry_comments/plugin.py", line 77, in actions
    action_list.append((self.get_title(group), self.get_url(group)))
  File "/var/sentry/sentryenv/lib/python2.6/site-packages/sentry_comments/plugin.py", line 39, in get_title
    count = GroupComments.objects.filter(group=group).count()
  File "/var/sentry/sentryenv/lib/python2.6/site-packages/django/db/models/query.py", line 388, in count
    return self.query.get_count(using=self.db)
  File "/var/sentry/sentryenv/lib/python2.6/site-packages/django/db/models/sql/query.py", line 428, in get_count
    number = obj.get_aggregation(using=using)[None]
  File "/var/sentry/sentryenv/lib/python2.6/site-packages/django/db/models/sql/query.py", line 394, in get_aggregation
    result = query.get_compiler(using).execute_sql(SINGLE)
  File "/var/sentry/sentryenv/lib/python2.6/site-packages/django/db/models/sql/compiler.py", line 840, in execute_sql
    cursor.execute(sql, params)
  File "/var/sentry/sentryenv/lib/python2.6/site-packages/django/db/backends/mysql/base.py", line 130, in execute
    six.reraise(utils.DatabaseError, utils.DatabaseError(*tuple(e.args)), sys.exc_info()[2])
  File "/var/sentry/sentryenv/lib/python2.6/site-packages/django/db/backends/mysql/base.py", line 120, in execute
    return self.cursor.execute(query, args)
  File "/usr/lib/pymodules/python2.6/MySQLdb/cursors.py", line 166, in execute
    self.errorhandler(self, exc, value)
  File "/usr/lib/pymodules/python2.6/MySQLdb/connections.py", line 35, in defaulterrorhandler
    raise errorclass, errorvalue
DatabaseError: (1146, "Table 'sentry.sentry_comments_groupcomments' doesn't exist")

It looks like that even I upgraded (migrated) the sentry databases, your plugins tables aren't created. Any ideas what I am missing?

Cheers,
Amir

Mail should contain event title

Currently it's a bit hard to guess to which event an comment belongs to since the mail only contains a link to the event group and the subject is "SOMEONE added a comment."

At least in the mail body the title of the event group should be mentioned. When using Sentry's mail templates the look and feel (including relevant information) should be much better.

Notification emails are text/plain but contain HTML markup

Steps to reproduce:

  1. Add a comment containing some text with an apostrophe, e.g. "but this can't possibly happen!"

What should happen: I get an email notification that says

but this can't possibly happen!

What actually happens: I get an email notification that has one text/plain MIME part with the following text:

but this can't possibly happen!

I see that < and > are also HTML-escaped unnecessarily.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.