andersla / terrashift Goto Github PK

The file that gets generated from inventory-openshift-template can be improved.

1. The ansible_ssh_user=centos section in the nodes section is not needed as this is specified globally by the ansible_ssh_user=centos setting

2. The ansible_ssh_host setting for the entries in the masters, etcd and nodes section might not be necessary if we run ansible from within the same VPC in which case we can use the private domain names of the servers?

1. Remove the bit that modifies /etc/sysconfig/docker. The ansible installer handles this automatically.

2. Consider installing NetworkManager after starting docker. I saw some errors when NetworkManager is installed when docker is not running. These probably are not serious, but installing NetworkManager later may be safer.

3. Remove the installation of Ansible and cloning the openshift-ansible repository. These are not needed for a node unless you want to run the the Ansible installer from it (e.g a master node)

Instructions for networking should be added.

1. Mention that the master public IP should added to DNS (e.g. as master.example.com) and a wildcard DNS entry added for that sub-domain (e.g. *.master.example.com)

2. Add these entries to the [OSEv3:vars] section:

openshift_hostname=MASTER_PRIVATE_FQDN
openshift_master_cluster_hostname=MASTER_PRIVATE_FQDN
openshift_master_cluster_public_hostname=MASTER_PUBLIC_FQDN
openshift_master_default_subdomain=MASTER_PUBLIC_FQDN

Where MASTER_PRIVATE_FQDN is the private DNS name of the master on AWS and MASTER_PUBLIC_FQDN is the public name of the server (e.g. master.example.com)

Some users may not understand git submodules and need some help in populating the openshift-ansible directory. Probably best to add this to the README.md file?

I think this would be something like this:

git submodule init
git submodule update
cd openshift-ansible/
git pull
git checkout master