and-rej / rotate-and-zoom-image Goto Github PK

Steps to reproduce

1. go to Instagram DM, notice an image rotated right
2. rotate it left
3. notice the image is cropped

Expected behavior

I can see the entire image

Actual behavior

Image is cropped, can see only a part of the image
Screenshot attached, so you can see.

https://github.com/mozilla/webextension-polyfill

I would like to try publishing the add-on for Google Chrome, but also to use browser instead of chrome. https://github.com/mozilla/webextension-polyfill may help

It could look something like this:

Steps to reproduce

1. Open https://vk.com/wall91523534_3881
2. Try to rotate image

Expected behavior

Image rotated

Actual behavior

Image wasn't rotated

I want to report that while zooming in, the image is beeeing cut-off in some parts (aspecially from the top and/or bottom) and it's restored while using the "reset" function. Please fix it asap because it makes hard to enjoy the pics while they are cropped and unable to scroll

Steps to reproduce

1. Visit a page that requires a reCAPTCHA image challenge e.g. http://demo.codeforgeek.com/google-captcha/
2. Click check box.
3. Right click image challenge and select a zoom option.

Expected behavior

Image should zoom.

Actual behavior

Nothing happens. Error in console.

I know this is not the purpose of this add on but it would be perfect if it could also show the image in negative (Inverted brightness) in addition to rotating, zooming and flipping.

Rotate 180° Left and Rotate 180° Right are the same result and thus redundant, so for simplicity just combine those to a single option to Rotate 180°.

I think it is more or less self-explanatory :)

How to use the add-on as well as how to contribute to the code or with l10n.

After #6 is implemented, it will be nice to be able to sync the settings for the user.

hi,

could you please replace : rotate 180 left and rotate 180 right by a simple rotate 180 in the menu ?
for me the result is the same, only the animation changes.

have a nice day,

Hello,

I am kind of newbie in firefox add-ons implementations. And I have a question, is there a way to remove the context menu item that opens the options?
I am trying to remove it from userChrome.css file but no result yet. Unable to find an id for the element.

Any advice would be very helpfull.

Thank you in advance!

Does not recognize images in an HTML5 canvas. An example of this is the "RRT-Connect algorithm" image at the bottom of this page. The image menu (rt click) does not contain the rotate-and-zoom-image option. Select 'View Image', and the resulting image is recognized by rotate-and-zoom-image, but any attempts to zoom or rotate are unsuccessful.

For reference, the "Image Zoom" FF extension handle[sd] this correctly, including allowing the demo to run resized.

To make more intuitive, what just happened.

From comment in https://addons.mozilla.org/firefox/addon/rotate-and-zoom-image/reviews/937656/reply

After using "Image Zoom" for quite some time, I finally found an alternative that works with Firefox 57+! Really hope options for downscaling (75% and 50%) would be added somewhere in the future :-)

It would be great if a combination of modifier key plus movement of the mouse wheel could be assigned to zoom in and out an image.

When hovering an image with the mouse pointer, if you hold the Alt key (or maybe other, just an example) and rotate the mouse wheel up, the image would zoom in and when rotating the mouse wheel down, the image would zoom out, so it wouldn't be neccesary to right click on the image and find the proper submenu option to achieve this.

It would be a similar behaviour as when you hold CTRL and rotate the mouse wheel and the page zoom changes dinamically, but limited just to the image under the mouse pointer.

Allow to configure rotation degrees and zoom levels.

Seems it does not work on images with links (so far I have noticed this directly on AMO, when trying to rotate the Firefox logo in the header). The possible cause is here, when the variable may got assigned to null by a subsequent call for the link context menu. I will need to verify first.

Having a shared variable is not a nice pattern in any case, but I do not see any obvious way to encapsulate it e.g. in an object instance at this moment. Maybe keeping a table of context menus opened for the document + the clicked images, and sending some ID back with the message...

I wanted to provide you with an image example. So, I went to POF and I found a random female profile. I right-clicked one of her pictures and selected "open image in new tab". This was the resulting URL link.

https://pics.pof.com/dating/1180/3/51/5149aea79-8bee-4825-9ee9-3c6cdb432244.jpg

I then tried doing two things.

1.) I tried zooming in to 400%. Then I used the page's horizontal and vertical scrollbars to see other parts of the picture. On the left side of the image, it was missing a lot of her head. I could only see maybe half of her forehead. On the top side of the image, there was a lot of image missing to the right of her face.

2.) I then did a full reset and rotated the image 90% to the right. I then zoomed in to 400%. I used the page's horizontal and vertical scrollbars to see other parts of the picture. On the left side of the image, there was a lot of image missing to the left of her face. On the top side of the image, it was missing most of her head. I could only see the bottom 25% of her eyes and nothing above her eyes like her forehead or hair.

You may get slightly different results using the above steps, as it might be dependent on how big your browser is and what your desktop resolution is. I am using a 1600x900 desktop screen resolution (you can change desktop screen resolutions in Display Settings). And the browser window was sized to around 1050x870. The truth is, even if I made my browser a little bigger like 1600x870 (taskbar covers up the bottom 30px), I would still have the same problem. Like in second example, everything above her eyes would still be cropped out. If you tried to replicate this issue, I would suggest maybe temporarily changing your desktop resolution to 1600x900 just in case. And if you get slightly different results, maybe try using a larger zoom like 500% - 900%. But this problem definitely does exist. It's been bothering me so long that I just never used the feature. In fact, I was just now looking online for another Firefox extension that could replace yours. But I only found one where it just rotates the image 90% to the right each time that you use it. It did not have flip and zoom features. So I thought maybe if I could get you to fix your extension, I could just stick with yours. I have seen in a previous post where this was blamed on child page elements and stuff like that. But the URL I provided you with is goes directly to an image with no other page elements. I may be wrong, but I think that this bug affects rectangle shaped images and not square shaped images. It probably affects all image shapes though. I just looked on the closed issue dates and this was reported almost 13 months ago. I can't believe no one has reopened this issue or that the issue hasn't been worked on or fixed in those 13 months. Let's try this again. (fingers crossed)

Add all relevant features from:

• https://addons.mozilla.org/firefox/addon/zoom-image/
• https://addons.mozilla.org/firefox/addon/image-resizer/
• https://addons.mozilla.org/firefox/addon/zoom-image-to-fit/

Please add a feature to flip images horizontally or vertically.

Hi, as now the bad quantum forced intall is hitting, they messed up with everything, so most add-on work no more I was using "Image rotate or flip" now I got your but seen with stupefaction and disdain that you have no flip option (horizontal and vertical) which is a must have, I removed the addon, I would reinstall if this is implemented in a very near future.

It would be quite nice if it could be controlled via mouse buttons/wheel - especially if the bindings would be configurable.

Moving a mouse pointer to the narrow field to expand a menu, without accidentally moving it off the field, can be slow. I suggest that some of the core items be moved to where they can be selected with "right click, select option, click", rather than "right click, hover mouse over field, slide mouse to right without hovering over another field, click". The items I recommend the most for this are 'fit to screen', 'fit to browser width', 'double current zoom', and/or 'halve current zoom'.

How Image Zoom handled zooming. It was the equivalent of changing the image's width and height in css, so elements on the page reacted to it.

How Rotate and Zoom Images handles it. Image simply becomes larger and elements on the page can be obscured by the image.

Another downside to the current method is that the image itself can be obscured when zoomed.

Hello.If you can just add where to rotate(left or right) it would be awesome and this will be perfect addon :) Thank you

Marko. T

https://addons.mozilla.org/cs/firefox/addon/rotate-and-zoom-image/reviews/915107/

A lot of websites today (including mozilla.org) do not use <img> tags, but include the some images via CSS background. This should be also supported to rotate or zoom.

So instead of checking if the element is <img>, I should include a check for background image, and find a way, how to rotate/zoom it possibly without moving the element itself and its content.

E.g. by putting a shadow around the image. Also adjust the z-index to pop in the foreground, when there is any transformation.

Allow to configure, if the animation is applied at all, as well as the animation speed (duration).