anatoliyv / assistantkit Goto Github PK

Detect if the display is zoomed or not

Hi,
It seems there is only detection for 12.9 inch iPad Pro, but no detection for 10.5-inch iPad Pro (screen resolution: 2224 × 1668 px)

Hi,
For iOS and macOS projets it's will be great to make your component Carthage compatible

Take a look at these articles:

• Ruthlessly Simple Dependency Management with Carthage
• Carthage Tutorial: Getting Started
• Making Carthage-compatible Frameworks with Swift
• Swift Cross Platform Framework (section Configure targets for Carthage) 👍

On your README.md add on top and add section for the installation with Carthage.

Hi,
It's will be great to create a Swift 3 version of your component

Article about Swift 3:

• Migrating to Swift 2.3 or Swift 3 from Swift 2.2

With Swift 3 it would also be nice to add support for SwiftPM

Articles about SwiftPM:

• Package.swift — The Manifest File
• Developing Packages
• System Modules
• Swift Package Manager Community Proposal

On your README.md add on top and add section for the installation with SwiftPM.

for push

Hi,
It would be nice if we could have some quick detections in cases when app is running in iPad Slide Over / Split View mode with different screen bounds being applied to it at runtime.

Best regards

Just installed AssistantKit and it looks very interesting. My iPhone 7 isn't detected, so I've created a pull request here: #7

Also, osVersion crashes because of Float(UIDevice.current.systemVersion)!. UIDevice.current.systemVersion returns 10.3.1 which can't be converted. I don't know what the best way to handle that is.

Devices with
case .phone6Plus,
.phone6SPlus,
.phone7Plus,
.phone8Plus:
return .inches_5_5

Don't have notch and they are in the static public var isNotched: Bool check

It would be great to have also this working.

Missing iPad 11 and iPhone XR resolutions

Unexpected version number in 'available' attribute for non-specific platform '*'
on Type.swift file
line: 180