anarcat / bup Goto Github PK

close failed in file object destructor:
sys.excepthook is missing
lost sys.stderr

23:42 <wrouesnel> -x is --one-file-system
23:42 <wrouesnel> so / /var would correctly determine that /var is shadowed by / and remove it
23:43 <@rlb> wrouesnel: ahh -- I suppose that makes some sense -- what about "index /var /"?
23:43 <@rlb> with -x?
23:43 <wrouesnel> it would do the same - the path reduction happens independent of -x
23:43 <wrouesnel> that's definitely a bug.
23:44 <@rlb> if nothing else, we should make sure the behavior is well documented -- whatever it does, and whatever we mean for it to do.
23:44 <wrouesnel> so reduce_paths needs to know about the -x flag, and check that any it wants to remove are on the same filesystem
23:44 <@rlb> I suppose I would have expected "-x / /var" to include both, but not cross any boundaries underneath them.

19:31 <anarcat>     sys.stdout.flush()
19:31 <anarcat> IOError: [Errno 9] Bad file descriptor
19:31 <anarcat>   File "/usr/lib/bup/cmd/bup-index", line 89, in update_index

diff --git a/cmd/index-cmd.py b/cmd/index-cmd.py
index b7fe8f1..3eedb31 100755
--- a/cmd/index-cmd.py
+++ b/cmd/index-cmd.py
@@ -87,7 +87,11 @@ def hashgen(name):
                                                  exclude_rxs=exclude_rxs):
         if opt.verbose>=2 or (opt.verbose==1 and stat.S_ISDIR(pst.st_mode)):
             sys.stdout.write('%s\n' % path)
-            sys.stdout.flush()
+            try:
+                sys.stdout.flush()
+            except IOError:
+               # probably stdout is closed, ignore
+               pass
             elapsed = time.time() - index_start
             paths_per_sec = total / elapsed if elapsed else 0
             qprogress('Indexing: %d (%d paths/s)\r' % (total, paths_per_sec))