amulet-team / construction-specification Goto Github PK

In almost all cases the shape of the construction file is not going to be a multiple of the chunk shape.
The two options are:

1. The chunks at the positive boundaries store a block array which is equal to the standard chunk size and when importing the part that overflows the construction shape is ignored
2. The chunks at the positive boundaries only store the block array contained within the construction shape

example:
If the construction shape is 8x8x8 blocks and the chunk shape is 16x16x16 blocks should the chunk that is stored contain

1. a 16x16x16 array of blocks but the upper 7/8ths of the chunk does not get imported
2. only a 8x8x8 array of blocks is stored for that chunk

The latter would be more memory effecient and the shape could be calculated based on the construction shape and the chunk shape.
Either way the specifics need to be documented.

Currently we define a single box for the shape of the construction file.
Are we wanting to keep it like that or modify it to support arbitrary selection boxes like the Selection class in Amulet can handle?
I would suggest keeping the whole box shape argument for the tools that cannot or don't want to support arbitrary boxes and adding another optional tag to support sub-selections.
The tag could just be an TAG_Int_Array with a multiple of six elements to define minimum and maximum of each box.

Good thing I made a backup of my world first. I wanted to delete all chunks from the world except those around my two home bases.

Steps:

1. Made sure Minecraft isn't running, backed up my world (zip the db folder)
2. Opened the world in Amulet
3. Set render distance to 16 so I could see all chunks I want to keep
4. Clicked on Chunk
5. Set view
6. Selected 87 chunks to keep
7. Clicked "Delete Unselected Chunks" with no recovery, waited for screen to finish updating
8. Exit program, select "Save" at the prompt
9. Progress dialog hangs with message "Not responding" in the title bar - no recovery after 1 hour

Trying this again, seemed to work OK if I selected "Save" from the drop-down menu first. This may be difficult to repeat. If there are any exception logs generated, I can attach them, but I don't know where they are if they exist.

Environment:

• Windows 10
• Bedrock Edition 1.17.0 (started the game in 1.14)
• Seed -513070979
• Explored almost the entire starting map
• Selected chunks covering spawn island, nearby island, and nearby ocean monument

Currently the dimensions of the block array is a fixed 16x16x16 array however it would be nice if the format did not restrict this. Even if it is not utalised it would be nice for the feature to be there.

Suggested implementation:
The array should be a fixed dimension across a construction file but can be changed between construction files with a key in the meta compound tag.
key in meta compound tag - "chunk_shape": TAG_List([TAG_Byte(), TAG_Byte(), TAG_Byte()])
Values corrospond to log(2, size) or size = 2^v
ie stored values corrospond to
0=1
1=2
2=4
3=8
4=16
...

In what format are data from blocks, entities and block entities going to be exported?
The data needs to be serialised into some format for saving, either into the java or bedrock format targetting a specific game version.
The data could be stored in the universal format but there is a chance things will break if the universal format gets changed so I don't much like this idea.
The specifics of this need to be documented and stored in the meta compound tag so that when it is imported the program knows how to deal with the data.

Is the shape tag the shape of the whole construction file in blocks or "chunks"?
This needs to be better described.
The shape in blocks makes more sense because you can work out the shape in "chunks" from that and the "chunk" shape