Fetch successful even when 404 about ampersand-model HOT 6 CLOSED

Does it really call a success if the error code is 404? In your example the server's responding with a 200, albeit html.

I'm fairly sure if the server were responding with an actual 404 code error would be triggered.

Still a valid question on whether we should be less liberal in accepting random html though. I guess it's hard because servers can sometimes be crappy about responding with html after e.g. a post request.

from ampersand-model.

Yes, the error code returned is 200 since it is coming from the SPA endpoint.
It does trigger an error when the http code is 404 (coming directly off the server).

from ampersand-model.

Okay, well that's good at least :)

In that case this is definitely a tricky one.

from ampersand-model.

Indeed.
I am played with the fetch and added a content check: https://github.com/stevelacy/ampersand-fetch-test/blob/master/node_modules/ampersand-model/ampersand-model.js#L59-L68 prototype only of course.

I then added three types of returns, json, html, and no-content.
The results: https://github.com/stevelacy/ampersand-fetch-test/blob/master/sc3.png
204 no content also errors, not sure if that is good behavior.
Thoughts to adding a content-type check option?

from ampersand-model.

This also occurs on the collection-rest-mixin in it's fetch function.

from ampersand-model.

Closing...

from ampersand-model.