Git Product home page Git Product logo

Comments (4)

pgilad avatar pgilad commented on July 22, 2024

It doesn't override, it just adds more properties to options.attrs that will be found in model.serialize().

I'm not sure if this is a mistake or not. If you can put together a test case for this it would be awesome.

from ampersand-model.

bryanspears avatar bryanspears commented on July 22, 2024

Certainly, it's not a direct override, but lets say I have a model with a, b, and c in it. b gets changed, mode is patch/wait true, which means at line 64, options.attrs = {b}, but after 67 it's {a, b, c}

Effectively overriding the object, but not the affected keys. Entirely obliterates the PATCH call purpose.

I should have a chance to write up a test tomorrow unless someone beats me to it.

from ampersand-model.

bryanspears avatar bryanspears commented on July 22, 2024

Excuse me. I shouldn't post when tired. We effectively said the same thing. 😄

from ampersand-model.

pgilad avatar pgilad commented on July 22, 2024

This is actually a duplicate of #13. Also see #23

from ampersand-model.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.