Git Product home page Git Product logo

Comments (5)

amosyuen avatar amosyuen commented on July 4, 2024

Thanks for drafting a fix.

From the docs https://docs.aiohttp.org/en/v3.8.5/client_reference.html#aiohttp.ClientSession.request, I see there is an ssl parameter, leaving it as None should use default behavior, and setting to False should disable the SSL check.

from ha-tplink-deco.

az01101001 avatar az01101001 commented on July 4, 2024

Yeah, but simply setting ssl to False somehow didn't fix the issue.

EDIT: I found this issue for Home Assistant Core with a similar problem and fix that maybe we can learn more from.

from ha-tplink-deco.

amosyuen avatar amosyuen commented on July 4, 2024

Seems strange that ssl to False doesn't work, but since the core change was similar to yours we can try using yours. My deco requires SSL so I can't test the non-ssl path, hopefully it works with others decos. Did you want to make a PR?

from ha-tplink-deco.

az01101001 avatar az01101001 commented on July 4, 2024

Just double-checked again, can confirm setting ssl to False doesn't work on my Deco. I'll finalize the changes then do a PR. You're right though, hopefully it doesn't break people's setups.

from ha-tplink-deco.

amosyuen avatar amosyuen commented on July 4, 2024

Change in release https://github.com/amosyuen/ha-tplink-deco/releases/tag/v3.5.2

from ha-tplink-deco.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.