amnestywebsite / humanity-theme Goto Github PK

Describe the bug
When I create a translation of a post or page, images in the 'image' block render in the translated post just fine. However, images that are a section block background, in the slider block, or in the header or banner block have to be re-added.

To Reproduce
Steps to reproduce the behavior:

1. Create a post with a slider / header / section block with background
2. Create a linked post for the translation
3. Copy the html from the original post into the translation post
4. Preview post - see that the images aren't there

Expected behaviour
When creating translations, all images should render in the translated post when the code is copied over.

Actual behaviour
Some images are copying over and some aren't.

Link to a page where the bug is reproduced in isolation
English post: https://isaidotorgstg.wpengine.com/en/latest/news/2022/06/test-post-images-in-translated-posts/
same post on the French site: https://isaidotorgstg.wpengine.com/fr/latest/news/2022/06/test-post-images-in-translated-posts/

Which site is this happening on
amnesty.org

Desktop (please complete the following information):
https://www.whatsmybrowser.org/b/X3ICW

Additional context
This is how translations are being done at the moment - the translator copies the html into a word doc, translates the text parts and pastes the code back into the post.

Overview

This overlaps with our initiative to update WordPress but this specify covers the non WordPress core parts of this work which is small.

https://github.com/amnestywebsite/amnesty-wp-theme/labels/Pillar%20-%20Bugs%20before%20features
https://github.com/amnestywebsite/amnesty-wp-theme/labels/Pillar%20-%20Content%20in%20CMS%20earlier

Goals

Be proud to say our theme is full supporting core WordPress features and where not have a good reason for not supporting a core feature.

Epics

• #130
• #131
• #133
• https://github.com/amnestywebsite/amnesty-wp-theme/issues/2905

Notes

Past discussions can be seen here

Describe the bug
é/É and e/E should be considered as separate letters on the Term A - Z block

To Reproduce
Steps to reproduce the behavior:
Steps to reproduce the behavior:

1. Go to https://www.amnesty.org/fr/countries/
2. Look at the A -> Z block
3. Look at E
4. Should not contain É

Expected behaviour
A tab for É and a tab for E

Actual behaviour
A tab for E that also contains É

Link to a page where the bug is reproduced in isolation (optional)
https://www.amnesty.org/fr/countries/

Screenshots

Additional context
Add any other context about the problem here.

https://wordpresstheme.amnesty.org/blocks/b028-term-a-z/

https://wordpresstheme.amnesty.org/blocks/b026-regions-list-block/

https://github.com/amnestywebsite/amnesty-wp-theme/issues/1645#issuecomment-1148565520

Feedback from Arabic translators the countries aren't in the correct order within each letter (i.e. alphabetical order by the second letter). Attaching a list showing the correct order provided by one of our Arabic translators.
220607 Country List A-Z Arabic.docx

I let them know that maybe we will go ahead as is and come to the second part later as it might take too much extra work.

Describe the bug
On the sidebar blocks added should have consistent widths

To Reproduce
Steps to reproduce the behavior:

1. Create a side bar
2. Add a recently added block
3. Add a CTA block
4. view widths of blocks in the side bar

Expected behaviour
expect the blocks fill the space in the side bar so they align on both the left and right

Actual behaviour
The blocks align on the left but not the right

Link to a page where the bug is reproduced in isolation (optional)
https://isaidotorgstg.wpengine.com/en/latest/news/2023/09/saudi-arabia-migrants-workers-who-toiled-in-amazon-warehouses-are-victims-of-trafficking-v3/

Screenshots

Platform:
Paste link from here https://www.whatsmybrowser.org/

Additional context
Add any other context about the problem here.

from https://github.com/amnestywebsite/internal/issues/100#issuecomment-1744656778

Describe the bug
On the donate form there is a drop down list of countries. The countries are in alphabetical order in English but not in Spanish, French and Arabic. It looks like the ES / FR / AR lists follow the English alphabetical order.

To Reproduce
Steps to reproduce the behavior:

1. Go to https://www.amnesty.org/fr/donate/
2. Click on 'sélectionner un pays' to open the drop-down list
3. Scroll down the list
4. See that the list is not in alphabetical order (e.g. Allemagne is between Géorgie and Ghana).

Expected behaviour
The drop down list of countries should be in alphabetical order in each language.

Actual behaviour
The order of the countries in the list follows the English alphabetical order and doesn't adapt in the other languages.

Link to a page where the bug is reproduced in isolation
https://www.amnesty.org/fr/donate/

Which site is this happening on
amnesty.org

Link to a page in the documentation site where the feature is described
https://wordpresstheme.amnesty.org/blocks/b017-donation-block/

Screenshots

Desktop (please complete the following information):
https://www.whatsmybrowser.org/b/X3ICW

Describe the bug
On the header block adding bold in the title remove a space

To Reproduce
Steps to reproduce the behavior:

1. Add a page
2. Add a header block
3. Some words and make on bold in the title
4. See error

Expected behaviour
There should be a space between each word

Actual behaviour
A space is missing between the words

Screenshots

Platform:
Paste link from here https://www.whatsmybrowser.org/

Additional context
https://github.com/amnestywebsite/amnesty-wp-theme/issues/1751

Describe the bug
On the Iframe button block the text is not viewable in the editor when button white and text is default "act now"

To Reproduce
Steps to reproduce the behavior:

1. Add a page
2. Add a button
3. Set button to white
4. Try and read the text

Expected behaviour
The text should have neough contract to be read

Actual behaviour
The text and background are both white

Link to a page where the bug is reproduced in isolation (optional)
URL so we can quickly see the issue

Screenshots

BUG - incorrect iFrame button styling colours

Switch to core WP navigation support and the in page menu https://wordpress.org/documentation/article/navigation-block/ https://wordpresstheme.amnesty.org/blocks/c010-menu/ hide existing (1)
Migrate to Core WP quote (3)

Sprints allocated

Number of sprints: 1
Link to sprint if known: TBC

Goals

• Improve the quote block
• Improve the navigation block

Think about (optional)

• Tickets for translations
• Tickets for content

Core WP Update - Gallery Block (3)
Migrate collapsible block to details block https://wordpress.org/documentation/article/details-block/ (3)
Support for group blocks (0)

Sprints allocated

Number of sprints: 1
Link to sprint if known: TBC

Goals

• Add Gallery
• Add details block
• Migrate collapsible block
• Support Groups block

Think about (optional)

• Tickets for translations
• Tickets for content

Sprints allocated

Number of sprints: 1
Link to sprint if known: TBC

Goals

• Make this theme easier to use by grass roots charities NGOs etc
• Remove dependency on CMB2

Think about (optional)

• Tickets for translations
• Tickets for content

Describe the bug
Logos that are not a pre defined limited size when uploaded are often stretched and distorted

To Reproduce
Steps to reproduce the behavior:

1. Go to theme options
2. Header
3. Upload a logo that is not 2167 by 918 pixels (867 by 200)
4. See error

Expected behavior
expect the logo to have a fixed height but the width to expand and contract with the aspect ratio of the image

Actual behavior
The height and width are both fixed so the image is stretch to match

Link to a page where the bug is reproduced in isolation (optional)
URL so we can quickly see the issue

Screenshots
Add screenshots or preferably a video / gif to help explain your problem.

Platform:
Paste link from here https://www.whatsmybrowser.org/

Additional context
we now have 4 sites with a custom logo

Describe the bug
On the related content feature when disabling in the CMS the option does not stay set to disabled

To Reproduce
Steps to reproduce the behavior:

1. Load a post with related content
2. Edit post
3. Disable Related content
4. content disappeared as expected
5. Re enable Related content
6. Re load CMS
7. The option is actually still set to disabled

Expected behaviour
Expected to see the option still set to enabled

Actual behaviour
Block is set to disabled

Link to a page where the bug is reproduced in isolation (optional)
https://www.amnesty.org/en/latest/news/2023/03/france-allowing-mass-surveillance-at-olympics-undermines-eu-efforts-to-regulate-ai/

Screenshots

Platform:
Paste link from here https://www.whatsmybrowser.org/

Additional context
Add any other context about the problem here.

As a work around we can edit the post meta

Describe the bug
On a translated page, the images are showing with the yellow candle, even though they have the copyright credit.

To Reproduce
Steps to reproduce the behavior:

1. create a new post.
2. add an image
3. create a linked translation, copying over the content.
4. see image is blocked and shows yellow candle.

Expected behaviour
Images shouldn't be blocked by the hide media plugin if they have the copyright credit in the description field in the media library.

Actual behaviour
Some images with copyright are getting blocked, e.g. on the Spanish language site.

Link to a page where the bug is reproduced in isolation
https://isaidotorgstg.wpengine.com/en/latest/news/2023/11/image-test/
https://isaidotorgstg.wpengine.com/es/latest/news/2023/11/image-test/

Which site is this happening on
amnesty.org

Desktop (please complete the following information):
https://www.whatsmybrowser.org/b/UVLBR

Additional context
This was raised by French translator, re this post: https://www.amnesty.org/fr/latest/news/2023/10/meta-failure-contributed-to-abuses-against-tigray-ethiopia/
I managed to fix the issue by re-adding the images to the post.

Describe the bug
When using a wide format component-template page, if I choose a non-default text size, it won't align to the edge of the container it's in.

(sorry this is a tricky one to describe...!)

To Reproduce
Steps to reproduce the behavior:

1. Create post
2. Select component template
3. Add text
4. Change size to 'small'
5. Set to align left
6. Doesn't go back to the left side of the page, stays in 'start' position.

Expected behaviour
Paragraph text in small, medium, large and extra large should behave the same as default.

Actual behaviour
Paragraph text in small, medium, large and extra large doesn't align back to the edge of the container, the way default does.

Link to a page where the bug is reproduced in isolation
https://isaidotorgstg.wpengine.com/en/latest/news/2022/05/text-alignment-in-different-sizes-paragraph/

I came across this when adding the disclaimer text above the map in this page: https://isaidotorgstg.wpengine.com/en/what-we-do/death-penalty/ (ended up using default size text for this on .org)

Which site is this happening on
amnesty.org

Link to a page in the documentation site where the feature is described
https://wordpresstheme.amnesty.org/administration/visual-regression-tests/paragraph-block/

Screenshots

Desktop (please complete the following information):
https://www.whatsmybrowser.org/b/X3ICW

Overview

In 2018 we adopted Guttenberg before it was in core and it not only felt good to know we were providing a cutting edge theme, but we could see the value it added to CMS users. We were and are able to boast of having a "Guttenberg theme", when this work is done we will be able to boast having a FSE or Block theme.

Rather than hiding new core WordPress Features we want to support and embrace where ever appropriate.

This will help us to get content into the CMS earlier, maintain security, continue providing customizations and onboarding and foster collaboration.

https://github.com/amnestywebsite/amnesty-wp-theme/labels/Pillar%20-%20WP%20Latest%20feature%20version

Goals

Be proud to say our theme is full supporting core WordPress features and where not have a good reason for not supporting a core feature.

https://github.com/amnestywebsite/amnesty-wp-theme/issues/2676

Epics

#119
https://github.com/amnestywebsite/amnesty-wp-theme/issues/2740
https://github.com/amnestywebsite/amnesty-wp-theme/issues/2741
https://github.com/amnestywebsite/amnesty-wp-theme/issues/2742
https://github.com/amnestywebsite/amnesty-wp-theme/issues/2748
https://github.com/amnestywebsite/amnesty-wp-theme/issues/2743
#122

Switch to core WP navigation support and the in page menu https://wordpress.org/documentation/article/navigation-block/ https://wordpresstheme.amnesty.org/blocks/c010-menu/ hide existing (1)
Migrate to Core WP quote (3)

• #123

Switch background media https://wordpresstheme.amnesty.org/blocks/b054-background-media/ to cover block https://wordpress.org/documentation/article/cover-block/ (big to migrate as used a lot)
Basic Audio block (before or after quote with alignment controls) - https://wordpress.org/documentation/article/audio-block/ (1)

• #124

Core WP Update - Gallery Block (3)
Migrate collapsible block to details block https://wordpress.org/documentation/article/details-block/ (3)
Support for group blocks (0)

• #125

Build footnotes block (1)
Dimension controls not support and why
Video not support and why https://wordpress.org/documentation/article/video-block/
sitemap block not support and why
review custom blocks like recipients and decommission blocks with low usage (content query)

Notes

Past discussions can be seen here
https://github.com/amnestywebsite/amnesty-wp-theme/issues/2448#issuecomment-1735884027
https://github.com/amnestywebsite/amnesty-wp-theme/discussions/2525

Describe the bug
On the RSS URL we are unable to filter by topic

To Reproduce
Steps to reproduce the behavior:

1. Go to https://www.amnesty.org/en/feed/?topic_name=technology-and-human-rights
2. See that content not in the technology-and-human-rights is present

Expected behaviour
Only content in the technology-and-human-rights should be present

Actual behaviour
Content that is not in the technology-and-human-rights is present

Link to a page where the bug is reproduced in isolation (optional)
URL so we can quickly see the issue

Screenshots
I would expect to see all post in the feed containing this item

however I see some posts that don't contain that topic

Looking at the documentation here from the .org migration

Additional context
I should be able to pass this URL
https://www.amnesty.org/en/feed/?topic_name=technology-and-human-rights

slug = technology-and-human-rights
ID = 2127
https://www.amnesty.org/en/search/?qtopic=2127

Overview

We always wanted to open source the theme, however we never got around to this. We now need to decommission the Berenson theme and we need to replace this, and we have learnt that maintain two themes is not feasible.

https://github.com/amnestywebsite/amnesty-wp-theme/labels/Pillar%20-%20Helps%20Open%20Source

Goals

• Remove barriers to using our theme
• Get access to the open source GitHub Tools
• Enable CSR and prono work
• Enable participation

Epics

• https://github.com/amnestywebsite/amnesty-wp-theme/issues/2659

• https://github.com/amnestywebsite/amnesty-wp-theme/issues/2660

• #127

Notes

Past discussions can be seen here
https://github.com/amnestywebsite/amnesty-wp-theme/discussions/2592

Describe the bug
On the Social icons block the styling has changed and is no longer on brand

To Reproduce
Steps to reproduce the behavior:

1. Add a page
2. Add social icons
3. We dont have a screen shot :-(
4. https://web.archive.org/web/20200222173941/https://www.amnesty.org/en/get-involved/

Expected behaviour
They should have padding and use the theme default not WP animation animations

Actual behaviour
we lost our styles

Link to a page where the bug is reproduced in isolation (optional)
https://www.amnesty.org/en/get-involved/

Screenshots
https://web.archive.org/web/20200222173941/https://www.amnesty.org/en/get-involved/
https://wordpresstheme.amnesty.org/blocks/b018-social-icons/

Describe the bug
If I want to format text so that it is 'medium' size, it won't align to the left. I can only align to the left if the text is formatted in the default paragraph text size.

To Reproduce
Steps to reproduce the behavior:

1. create a post
2. add paragraph text
3. change text size to medium
4. format to align left
5. preview post - see that the text stays in the default, no alignment, position.

Expected behaviour
I want paragraph alignment to function in the same way regardless of text size.

Actual behaviour
Link to a page where the bug is reproduced in isolation
http://isaidotorgstg.wpengine.com/en/latest/news/2022/05/text-alignment-in-different-sizes-paragraph/
^looking at this, you can see that it also doesn't align as far to the right either. it's like the non-default-size text alignment works within a narrower container or something.

Which site is this happening on
amnesty.org

Link to a page in the documentation site where the feature is described
URL so we can quickly see how it is supposed to work
https://wordpresstheme.amnesty.org/administration/visual-regression-tests/paragraph-block/

Screenshots
I came across this whilst drafting up this page: https://www.amnesty.org/en/wp-admin/post.php?post=174207&action=edit

I want the text to be medium, and to align with the heading on the left:

Desktop (please complete the following information):
https://www.whatsmybrowser.org/b/X3ICW

In several places, we make use of exclusions to prevent the current post from being present in certain queries — related content, for example — which is not the most performant way of performing this type of query.
We should inspect and, where practicable, adjust this methodology to better leverage query caching via Memcached.
For example, we could retrieve more rows than we need, store them in the cache, and then filter using PHP.

Search the codebase for // phpcs:ignore WordPressVIPMinimum.Performance.WPQueryParams.PostNotIn_post__not_in to find such instances. Note: this code search will only show results after the PHP 8.2 upgrade has taken place.

Read more here: https://docs.wpvip.com/technical-references/code-quality-and-best-practices/using-post__not_in/

Normally this would have been a discussion first, but we are discussing this here as we are working on this already.

When the issue https://github.com/amnestywebsite/amnesty-wp-theme/issues/2708 was addressed this applied a max 860px on paragraphs. However this ticket was released by accident when migrating the theme to the new repos. Rather than roll back or hot fix we will try to add some new criteria here.

This change makes the text easier to read which is good for accessibility, but leave some strange empty spaces from a design perspective.

https://www.amnesty.org/en/latest/research/2023/10/repression-trade/

White sections

Grey Sections

sections in tabs block

Other text blocks such as paragraphs, headers, block, quotes etc

We also need to consider the companion plugin and the country pages that uses a different layout size, our chosen solution if possible should use the same logic as posts (with and without side bars) and pages, and we can hopefully can reduce the differences between templates here too.

https://www.amnesty.org/en/location/asia-and-the-pacific/south-asia/afghanistan/

.container--small {
    max-width: 1113px; 
}

on pages with a side bar the change looks fine as there is very little difference between the 860px limit and the previous limit.
https://www.amnesty.org/en/latest/news/2024/03/eu-artificial-intelligence-rulebook-fails-to-stop-proliferation-of-abusive-technologies/

.article.has-sidebar {
    max-width: 900px;
}

some things we will think about

• Consider - add a option to section block to constrain width
• Consider - use 3 columns
• Consider - add the restricted style when the txt is wider than a certain width
• Consider other options
• Consider - making it easy for the CMS user
• Consider - Consider - reducing differences between templates
• Consider - keep complexity low (we dont want to replicate this https://github.com/amnestywebsite/amnesty-wp-theme/issues/2353 which was to reduce the content "breaking out")

@Gentyspun will have a look locally then get back to us with some thoughts.

Describe the bug
On the Spanish site, there is no '.' to separate the thousands in the counter block.

To Reproduce
Steps to reproduce the behavior:

1. insert counter block
2. enter number in the thousands
3. see no separator

Expected behaviour
In Spanish thousands should be separated by a dot.

Actual behaviour
the counter block doesn't accommodate this.

Link to a page where the bug is reproduced in isolation
https://www.amnesty.org/es/what-we-do/death-penalty/

Which site is this happening on
amnesty.org

Link to a page in the documentation site where the feature is described
https://wordpresstheme.amnesty.org/blocks/b022-counter/

Screenshots

Additional context
looks ok in English, French and Arabic, which use either a comma or a space as a separator.

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Go to https://www.amnesty.org/en/sitemap_index.xml
2. See no content is listed

Expected behaviour
Expect to see content in the sitemap

Actual behaviour
There is no content in the sitemap

Link to a page where the bug is reproduced in isolation (optional)
https://www.amnesty.org/en/sitemap_index.xml

Additional context

Describe the bug
If I accidentally add a 'updated at' date to a post I can't take it off again.

e.g. https://www.amnesty.org/en/latest/news/2023/04/turkiye-people-with-disabilities-neglected-in-humanitarian-response-to-devastating-earthquake/

or maybe I just don't know how to?

To Reproduce
Steps to reproduce the behavior:

1. add new post
2. click on 'choose date' next to 'updated at' in the post settings
3. select a date
4. publish
5. See post had published date and updated date
6. go back to edit the post and try to remove the updated date
7. can't do it!

Expected behaviour
should be able to undo the updated at date in case it was selected by accident.

Actual behaviour
once you've added an updated at date you can't take it off again

Link to a page where the bug is reproduced in isolation
https://isaidotorgstg.wpengine.com/en/latest/news/2023/04/updated-time-stamp-test/

Which site is this happening on
amnesty.org

Desktop (please complete the following information):
https://www.whatsmybrowser.org/b/AZ83C

Switch background media https://wordpresstheme.amnesty.org/blocks/b054-background-media/ to cover block https://wordpress.org/documentation/article/cover-block/ (big to migrate as used a lot)
Basic Audio block (before or after quote with alignment controls) - https://wordpress.org/documentation/article/audio-block/ (1)

Sprints allocated

Number of sprints: 1
Link to sprint if known: TBC

Goals

• Switch to cover block
• Add basic audio support

Think about (optional)

• Tickets for translations
• Tickets for content

Describe the bug
When I add a video to the header block, the block doesn't show the copyright credit from the video. Instead the copyright credit from the featured image shows.

To Reproduce
Steps to reproduce the behavior:

1. add a new post
2. add a header block, select 'video' background type and add a video
3. add a featured image as well
4. preview post and see featured image copyright credit showing over the video.

Expected behaviour
When users see the video they should see the correct copyright credit.

Actual behaviour
The wrong copyright credit is showing on the video.

Link to a page where the bug is reproduced in isolation
https://isaidotorgstg.wpengine.com/en/latest/news/2024/01/header-block-video-copyright-credit/

Which site is this happening on
www.amnesty.org

Link to a page in the documentation site where the feature is described
https://wordpresstheme.amnesty.org/blocks/b000-header/

Screenshots

Desktop (please complete the following information):
https://www.whatsmybrowser.org/b/EPIA9

Describe the bug
When using the post list block on amnesty.eu, I tried to set up a 'Taxonomy' type post list, using the 'Resource Type' taxonomy and showing only posts tagged with 'Council of Europe and ECHR'. It looked like it was working fine in the WordPress editor, but then it just disappeared on the front end! In preview and when the post was published.

The block seems to work with other taxonomies: Countries, Topics and Content Types.

To Reproduce
Steps to reproduce the behavior:

1. add post
2. insert post list block
3. in the block settings, select style: grid, type: taxonomy, taxonomy: resource type, terms: council of europe and echr (or any of the other resource types)
4. preview the post
5. See the post list doesn't appear on the front end.

Expected behaviour
post list block should show on the front end for all available settings.

Actual behaviour
it's not working when you filter for the resource type taxonomy

Link to a page where the bug is reproduced in isolation
https://www.amnesty.eu/wp-admin/post.php?post=20276&action=edit

Which site is this happening on
amnesty.eu

Link to a page in the documentation site where the feature is described
https://wordpresstheme.amnesty.org/blocks/b013-list/

Desktop (please complete the following information):
https://www.whatsmybrowser.org/b/AZ83C

Sprints allocated

Number of sprints: 1
Link to sprint if known: TBC

Goals

• Improve typography controls
• paragraph
• colour
• alignment
• pallet controls

Describe the bug
On the CSP Plugin in the editor some of the checkboxes states do not persist when the page is reloaded

To Reproduce
Steps to reproduce the behavior:

1. Go to CSP settings
2. Click on Global CSP Flags > Report Only Report CSP violations without enforcing the policy.
3. Save
4. reload the page
5. See error

Expected behaviour
The sate should persist

Actual behaviour
the state does not persist

Additional context
Also
media-src
self Only allow resources from the current origin.

For now we are going to try and change the field directly in the DB

The list block has no options to change the alignment to left or right aligned. This causes problems for text in Arabic, which is right aligned and for English text, in the wider format 'component template' pages, which is left aligned.

To Reproduce
Steps to reproduce the behavior:

1. Create post
2. Set to component template
3. insert text, including list
4. align paragraph blocks to the left
5. you will see the list block are now out of alignment with the rest of the text

Expected behaviour
Option to align the list block should be available in the block formatting options.

Actual behaviour
No options to align the list block.

Link to a page where the bug is reproduced in isolation
https://isaidotorgstg.wpengine.com/en/latest/news/2022/05/list-block-alignment-en-ar/

Which site is this happening on
amnesty.org

Link to a page in the documentation site where the feature is described
https://wordpresstheme.amnesty.org/administration/visual-regression-tests/list/

Describe the bug
The default font when used in heading and paragraphs is hard to read, and in paragraphs can not be distinguished from bold and non bold text

To Reproduce
Steps to reproduce the behavior:

1. Add a page or post
2. add some text
3. add some more and set it to bold
4. view the post

Expected behavior
Expect to see a visible difference between bold and non bold text

Actual behavior
both bold and non bold look the same

Additional context
My guess is that it is due to using a display font which is heavy already
https://fonts.google.com/specimen/Playfair+Display
and we might need to use something like
https://fonts.google.com/specimen/Playfair
or even both, one used in titles and one used elsewhere

What do you think?

Sprints allocated

Number of sprints: 1
Link to sprint if known: 94

Goals

Tickets to complete:
https://github.com/amnestywebsite/amnesty-wp-theme/issues/2787 create theme.json file
https://github.com/amnestywebsite/amnesty-wp-theme/issues/2788 create header template
https://github.com/amnestywebsite/amnesty-wp-theme/issues/2789 create footer template
https://github.com/amnestywebsite/amnesty-wp-theme/issues/2790 create 404 template

Improve the FSE support for the theme

copied from here https://github.com/amnestywebsite/amnesty-wp-theme/issues/2739
PR #104

Epic and sprint owner

@AmnestyAM

Some background info here #https://github.com/amnestywebsite/internal/issues/594

Sprints allocated

Number of sprints: one (This will take longer)

Goals

So the scope here extended a bit, we not only want patterns but also block templates.

Build 4 block templates
Build patterns for templates

Block Templates - In brand plugin

• Report - https://github.com/amnestywebsite/amnesty-wp-theme/issues/2932
• Perspective - https://github.com/amnestywebsite/amnesty-wp-theme/issues/2934 (no patterns RQD)
• Press Release Plus https://github.com/amnestywebsite/amnesty-wp-theme/issues/2933
• Issue or Project Page https://github.com/amnestywebsite/amnesty-wp-theme/issues/2935

Patterns - In Humanity theme

• #171
• #172
• #173
• #174
• #175
• #176
• #177
• #178
• #179
• #180
• #181
• #132

Other

• #182
• #184
• #183
• #185
• #186
• #201

Describe the bug
The Multisite Global Media plugin doesn't hook into wp_get_attachment_url, which impacts some of our blocks when they reference media uploaded to a different site.

Blocks understood to be affected:

• Header/banner (background video attribute)
• Download block (file URI retrieval in render)

To Reproduce
Steps to reproduce the behaviour:

1. On a multisite, activate the Multisite Global Media plugin
2. On the main site, upload a video
3. On a subsite that isn't the main site, visit WP Admin
4. Create/Edit a post/page
5. Insert a Header block
6. Set the background video to be the video uploaded in step 2
7. Save and view the post/page
8. See that the video doesn't render in the Header

Expected behaviour
The video should render

Actual behaviour
The video doesn't render. The <video> and <source> tags are inserted into the DOM, but the src attribute of the <source> tag is missing.

Link to a page where the bug is reproduced in isolation (optional)
https://isaidotorgstg.wpengine.com/es/latest/news/2024/01/test-header-block-video-spanish/

Screenshots

Platform:
https://www.whatsmybrowser.org/b/9Q2N5

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Add content and a side bar to a PAGE
2. Click "Maximize Content"
3. See page has not maximised

Expected behaviour
The text on the first option indicates ticking the "Maximize Content" should be sufficiency to maximise the area

Actual behaviour
You need to select disable sidebar too

Screenshots

Describe the bug
When using the slider block, if I turn 'show tabs' off, the right hand arrow on the first slide doesn't appear when I first load the page.

It does appear once I've swiped to the next slide and back.

To Reproduce
Steps to reproduce the behavior:

1. Create new post
2. Add slider block and insert a few slides
3. Toggle off 'show tabs' in the block settings
4. view post and see the arrow missing from the first slide

Expected behaviour
Hiding the tabs shouldn't affect the arrows.

Actual behaviour
Hiding the tabs takes away the arrow on first slide.

Link to a page where the bug is reproduced in isolation
https://isaidotorgstg.wpengine.com/en/latest/news/2022/08/slider/

Which site is this happening on
amnesty.org

Link to a page in the documentation site where the feature is described
https://wordpresstheme.amnesty.org/blocks/b006-timeline-slider/

Screenshots

Desktop (please complete the following information):
https://www.whatsmybrowser.org/b/X3ICW

Additional context
Could it be related to this? https://github.com/amnestywebsite/amnesty-wp-theme/issues/805

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Go /wp-admin/themes.php
2. See image not loaded

Expected behaviour
The theme image should be shown

Actual behaviour
No image is shown

Link to a page where the bug is reproduced in isolation (optional)
/wp-admin/themes.php

Screenshots

Tickets slated for release

• #116
• #22
• #33
• #99
• #100
• #118
• https://github.com/amnestywebsite/amnesty-wp-theme/issues/2388 trigger full width menu and hide burger at 1024px
• https://github.com/amnestywebsite/amnesty-wp-theme/issues/2586 adds a 40 px gutter to the content area
• https://github.com/amnestywebsite/amnesty-wp-theme/issues/2685 removed an unnecessary page option
• https://github.com/amnestywebsite/amnesty-wp-theme/issues/2698 fixed some spacing issues on the header block
• https://github.com/amnestywebsite/amnesty-wp-theme/issues/2780 made it easier to edit title and tags on post list block
• https://github.com/amnestywebsite/amnesty-wp-theme/issues/2786 fixed margin on links with icon block
• https://github.com/amnestywebsite/amnesty-wp-theme/issues/2833 better lag support for ZH
• https://github.com/amnestywebsite/amnesty-wp-theme/issues/2853 removed feature / header images from showing twice
• https://github.com/amnestywebsite/amnesty-wp-theme/issues/2884 fixed the size options on header block

Internal Issues

• https://github.com/amnestywebsite/amnesty-wp-theme/issues/2390
• https://github.com/amnestywebsite/amnesty-wp-theme/issues/2512
• https://github.com/amnestywebsite/amnesty-wp-theme/issues/2555
• https://github.com/amnestywebsite/amnesty-wp-theme/issues/2595
• https://github.com/amnestywebsite/amnesty-wp-theme/issues/2659
• https://github.com/amnestywebsite/amnesty-wp-theme/issues/2851
• https://github.com/amnestywebsite/amnesty-wp-theme/issues/2892
• https://github.com/amnestywebsite/amnesty-wp-theme/issues/2893
• https://github.com/amnestywebsite/amnesty-wp-theme/issues/2895
• https://github.com/amnestywebsite/amnesty-wp-theme/issues/2896
• https://github.com/amnestywebsite/amnesty-wp-theme/issues/2897
• https://github.com/amnestywebsite/amnesty-wp-theme/issues/2898
• https://github.com/amnestywebsite/amnesty-wp-theme/issues/2902
• https://github.com/amnestywebsite/amnesty-wp-theme/issues/2819

Automated tests

• GhostInspector tests run as expected
• New GhostInspector tests tickets created (if needed)

Checks

• List any new translation strings
• Verify new code meets WCAG standards
• Verify L2R and R2L
• Document for anything new/changed

Version number

• Theme: v1.0.1
• Branding: v1.0.1
• SP Runner: v2.1.0
• Theme Companion: v2.2.0

Scheduled release date

• Thursday 11th April 2024

Describe the bug
On the join block modal review accessibility

To Reproduce
Steps to reproduce the behavior:

1. Go to https://www.amnesty.org/en/get-involved/join/
2. Tab to Join Now
3. See focus

Expected behaviour
We should trap the focus within the modal when activated via keyboard or screen reader

Actual behaviour
The join modal is lacking in accessibility support. Specifically, it doesn't trap focus within the modal when activated via keyboard or screen reader.

Link to a page where the bug is reproduced in isolation (optional)
https://www.amnesty.org/en/get-involved/join/

Screenshots

Describe the bug
When the slider block is added to the homepage it occupies 100% of the page width

To Reproduce
Steps to reproduce the behavior:

1. Go to EU site
2. zoom out
3. Notice the slider is taking up 100% of the width

Expected behaviour
The content should not break out past the menu or footer

Actual behaviour
The content breaks out past the menu and footer and goes to the edges of the page

Link to a page where the bug is reproduced in isolation (optional)
https://www.amnesty.eu/latest-news/
https://wordpresstheme.amnesty.org/blocks/b006-timeline-slider/

Screenshots

Describe the bug
On the header block the backgound colour is missing for all content where none was set in the past is no longer an option so we should default to black for old content

To Reproduce
Steps to reproduce the behavior:

1. Set a post to the old none value (I guess in the database)
2. Click on view the post see something like this https://www.amnesty.org/en/latest/research/2022/12/older-people-ukraine-war-displacement-and-access-to-housing/
3. See there is no backgound set

Expected behaviour
White text should have the black background

Actual behaviour
There is no backgound colour on the text

Link to a page where the bug is reproduced in isolation (optional)
URL so we can quickly see the issue

Screenshots

https://github.com/amnestywebsite/amnesty-wp-theme/issues/2355#issuecomment-1750188967

The bug
Amnesty Core Blockquote block displays in default alignment single opening quotation mark. This mark is absolutely positioned. For some languages the opening quotation mark is '„' instead of '“'. In such case, the mark goes under the quotation content.

To Reproduce
Steps to reproduce the behaviour:

1. Create Blockquote Block with Alignment set to "Default"
2. Change website language to Polish or German.
3. Blockquote Block has now improper design both in back-end and front-end.

Solution
The simplest solution is adding to theme CSS:
.blockquote.blockquote:not(.align-start):not(.align-end) { quotes: '”' '”' "’" "’"; }

Additional concerns
https://wordpresstheme.amnesty.org/wp-content/themes/amnesty-wp-theme-16/assets/styles/bundle.css?ver=1.23.0 _blocquote.scss includes a lot of '!important' statements. This should be avoided and replaced by more specific selectors. Reversing the order of precedence is considered as bad practice when one can easily avoid it and has no security related reasons to do this. The most obvious is its impact on assistive technologies and accessibility.

https://github.com/amnestywebsite/amnesty-wp-theme/issues/2747
Build footnotes block (1)
Dimension controls not support and why
Video not support and why https://wordpress.org/documentation/article/video-block/
sitemap block not support and why
review custom blocks like recipients and decommission blocks with low usage (content query)

Sprints allocated

Number of sprints: 1
Link to sprint if known: TBC

Goals

• Explain whey we will not support remaining blocks
• add footnote support

Think about (optional)

• Tickets for translations
• Tickets for content

Describe the bug
The hide media plugin is working on featured images and header blocks but not on the image block, slider block, section block and other blocks with images, in the body of the post.

To Reproduce
Steps to reproduce the behavior:

1. add new post
2. insert image with no copyright credit
3. see image still shows on the front end

Expected behaviour
all images with no copyright credit should be blocked by the hide media plugin.

Actual behaviour
Only featured images and header block images are blocked.

Link to a page where the bug is reproduced in isolation
https://isaidotorgstg.wpengine.com/en/latest/news/2023/12/testing-hide-media-plugin/
https://isaidotorgstg.wpengine.com/es/latest/news/2023/12/testing-hide-media-plugin/

Which site is this happening on
amnesty.org

Desktop (please complete the following information):
https://www.whatsmybrowser.org/b/UVLBR

Additional context
This may have been going on for a while so if we get it fixed there might be a bit of a backlog of images to to add copyrights to on amnesty.org.

Describe the bug
On the "Call to Action" block when you add a button the wrong Button block is added

To Reproduce
Steps to reproduce the behavior:

1. Add a page
2. Add a CTA block
3. Add a button
4. Notice the size of the buttons

Expected behaviour
Expect the same size button to be added

Actual behaviour
A smaller button is added

Link to a page where the bug is reproduced in isolation (optional)
URL so we can quickly see the issue

Screenshots

Describe the bug
We used to have four style options for the buttons block but they're not all there any more. We just have two styles now, called 'fill' (yellow) and 'outline'. So we're missing the black button and the breadcrumb button.

To Reproduce
Steps to reproduce the behavior:

1. add new post
2. add button block
3. see reduced style options in block settings.

Expected behaviour
we should have the usual four styles for buttons.

Actual behaviour
only 'fill' and 'outline' are available.

Link to a page where the bug is reproduced in isolation
https://isaidotorgstg.wpengine.com/en/latest/news/2023/03/buttons-test/

Which site is this happening on
amnesty.org

Link to a page in the documentation site where the feature is described
https://wordpresstheme.amnesty.org/administration/visual-regression-tests/b019-button-test/

Desktop (please complete the following information):
https://www.whatsmybrowser.org/b/AZ83C

Regression tests to be updated:
https://wordpresstheme.amnesty.org/administration/visual-regression-tests/b019-button-test/

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Go to https://www.amnesty.org/fr/commander/
2. See translations are not in the correct language

Expected behaviour
French pages should show French translations

Actual behaviour
French pages show English translations

Link to a page where the bug is reproduced in isolation (optional)
https://www.amnesty.org/fr/commander/

Screenshots

https://github.com/amnestywebsite/amnesty-wp-theme/issues/1917

Describe the bug
On the tabs block the main or first tab stays highlighted even when other tabs have been selected

To Reproduce
Steps to reproduce the behavior:

1. Add a post
2. Add a tabs block plugin (required the tabs block plugin)
3. publish
4. See the main tab is highlighted when clicking between tabs

Expected behaviour
Only one tab should be underlined at a time

Actual behaviour
The first tabs stays highlighted and subsect tabs are highlighted as well

Link to a page where the bug is reproduced in isolation (optional)
https://isaidotorgstg.wpengine.com/en/latest/news/2024/02/test-tabs/

Screenshots

https://isaidotorgstg.wpengine.com/en/latest/news/2024/02/test-tabs/

All issues tracked here ->

Full site editing brings with it a new paradigm for block registration. Whereas previously blocks could be entirely crafted with JavaScript, or as a combination of JavaScript and PHP, FSE now enforces the latter.

This means that blocks that are entirely crafted using JavaScript are no longer visible in the editor, and will need converting to use the new registration methodology.

Epic and sprint owner

tbc

Sprints allocated

Number of sprints: 2
Link to sprint if known: TBC

Goals

• Add Full Site Editing support for "old" blocks

Add Full Site Editing support for "old" blocks

Tickets

• #141
• #142
• #143
• #144
• #145
• #146
• #147
• #148

Describe the bug
The header block has the option to change the 'background type' to video, rather than image. This feature doesn't seem to work in the Spanish site. You can add the video but it doesn't show up on the front end.

To Reproduce
Steps to reproduce the behavior:

1. on a Spanish language site
2. create a post, add header block
3. select 'background type' video and add a video and a featured image
4. preview post - can't see the video! just the image shows.

Expected behaviour
video feature should work on the header block - across all languages.

Actual behaviour
It worked on amnesty.org/en but not on amnesty.org/es.

Link to a page where the bug is reproduced in isolation
https://isaidotorgstg.wpengine.com/es/latest/news/2024/01/test-header-block-video-spanish/
https://isaidotorgstg.wpengine.com/en/latest/news/2024/01/test-header-block-video-spanish/

Which site is this happening on
amnesty.org

Link to a page in the documentation site where the feature is described
https://wordpresstheme.amnesty.org/blocks/b000-header/

Desktop (please complete the following information):
https://www.whatsmybrowser.org/b/EPIA9

Additional context
Issue came up from a translator working on this page: https://www.amnesty.org/es/latest/news/2024/01/united-states-lives-devastated-and-human-rights-sacrificed-by-toxic-fossil-fuel-related-pollution-from-petrochemical-plants-in-texas-and-louisiana/

I think it was also previously an issue on this page: https://www.amnesty.org/es/latest/news/2023/09/drc-cobalt-and-copper-mining-for-batteries-leading-to-human-rights-abuses/