amitp / mapgen2 Goto Github PK

Sorry I'm going all nitpicky here...

In assignCornerElevations there are two loop over corners where they could be combined.

I found buildNoisyEdges function couldn't handle this form of quadrilateral because intersections of 2 lines (edge.v0, edge.v1 and edge.d0, edge.d1) will lie outside of their quadrilateral and makes its noisy edge overlap neighboring edges.

I think this can be solved can restructure this shape into solvable one that you wrote on your blog.

For example:

Where:
A, B: Voronoi points.
C, D: Delaunay points.
H: intersection of AB and CD.

We can try to reform this ACBD into AC1BD1 before passing it into buildNoisyEdges function. C1 and D1 are intersections of a line that goes through B and AC / AD respectively.

I'm currently porting Map.as to Lua so I'm reading the code very thoroughly. I just stumbled about something that I'd consider bad performance, but I have no experience in ActionScript at all, or means to test my findings, so I might be wrong.

In the loop start at Map.as:375 over the libedges function you create the function addToCornerList and addToCenterList. I think if those two are created outside the loop it should be the same result at better performance?

On line 480 in map.as, you use:

if (!s.water && !s.water){
newElevation += 1;
}

Is this intentional? If so, why? Did you intend to use:

if (!q.water && !s.water){
newElevation += 1;
}

I have the following error when I execute mxmlc -source-path+=third-party/PM_PRNG -source-path+=third-party/as3delaunay/src -source-path+=third_party/as3corelib mapgen2.as

$ mxmlc -source-path+=third-party/PM_PRNG -source-path+=third-party/as3delaunay
/src -source-path+=third_party/as3corelib mapgen2.as
Cargando el archivo de configuraci¾n C:\Users\SabinaPC\Desktop\holas\frameworks
flex-config.xml
Adobe Flex Compiler (mxmlc)
Version 4.6.0 build 23201
Copyright (c) 2004-2011 Adobe Systems, Inc. Reservados todos los derechos.

command line: Error: no se puede abrir æthird_party/as3corelibÆ

Use la ayuda de 'mxmlc para obtener informaci¾n sobre el uso de la lÝnea de coma
ndos.

I download the source, write git submodule update --init and i don have error messages. I am new in it and I'm fascinated with your proyect