Problems with Mac version about electron-markdownify HOT 5 CLOSED

@amitmerchant1990 I'd love to help. I'll try to get a PR together in the next few days. ☺️

from electron-markdownify.

@amitmerchant1990 Here's what I've got (working nicely). Let me know if you want to add any more info:

electron-packager . Markdownify 
--platform=darwin \
--arch=x64 \
--asar=true \
--icon=./img/markdownify.icns \
--overwrite=true \
--prune=true \
--version=0.36.12 \
--app-version=1.1.6

I strongly recommend you use some kind of task runner to do this for you so it can dynamically grab the app-version and version of electron you're using. See here. Otherwise you'll have to update those values every time you build. I can set this up for you too if you want.

from electron-markdownify.

Hi @atdrago, Thanks for trying out Markdownify. For the issue, actually I have packaged all bundles for specific platforms using electron-packager. I have tested it for Linux and Windows thoroughly. But as I don't have any machine containing Mac I didn't get chance to test the app on it.

It would be appreciated if you build the bundle for Darwin on your machine and then test it. Let me know if it's sounds good to you. 😄

from electron-markdownify.

@amitmerchant1990 Could you paste the full electron-packager command with the parameters you use here? I'll add it as an npm script to your package.json. Or is this already somewhere in the project?

from electron-markdownify.

Hi @atdrago The command I have used for packaging bundles for all platform is as below:

electron-packager . Markdownify --platform=all

So, this will generate all of the bundles. I haven't specified the parameters you've mentioned. Did that would be the reason it was crashed in Mac?

Regarding the task runner thing, yes, it would be good if you set it up for me. I'd definitely want to try my hands on Gulp.

from electron-markdownify.