Git Product home page Git Product logo

Comments (4)

amitmerchant1990 avatar amitmerchant1990 commented on May 24, 2024

Hi @patricknelson Yes. I'm aware aware about issue and it's being occurring due to globalShortcut module of Electron. So, until the solution of the same doesn't come out, we need to try another way out. I'll work on it and try to fix it soon.

from electron-markdownify.

patricknelson avatar patricknelson commented on May 24, 2024

I see. I just looked into this a bit, cloned and rebuilt this repo and looked the code a little deeper. They're never going to fix that I think because it would go against the purpose of the module, as it's always going to be OS-level shortcuts. So, as long as you're calling globalShortcut.register('CmdOrCtrl+Shift+t', ...) then people use these shortcuts OUTSIDE of the app are going to drop this app instantly because of the conflict in the separation of concerns.

I'd suggest finding a way to listen to all of these events on the document element or adding them as menu entries. It just might be a little more difficult since you won't be able to use the nice cross-OS compatible syntax (e.g. CmdOrCtrl+Shift+t) but I'm sure it's still doable. For now this sort of kills the app for me, unfortunately.

from electron-markdownify.

patricknelson avatar patricknelson commented on May 24, 2024

p.s. Here's a related discussion that I found which covers this topic on the module itself electron/electron#1334

Based on what I'm seeing at the bottom I'll submit a quick PR for you to test out an alternative!

from electron-markdownify.

amitmerchant1990 avatar amitmerchant1990 commented on May 24, 2024

#15 this. Closing the issue.

from electron-markdownify.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.