amitlevy21 / lets-go Goto Github PK

View Code? Open in Web Editor NEW

0.0 0.0 0.0 89 KB

Let's Go - Transportation monitoring system

License: MIT License

Go 100.00%

golang tdd

lets-go's People

Contributors

Watchers

lets-go's Issues

Create error handling types

Use types like stationExist for more readable and reliable checks

lets-go/ride/route.go

Lines 22 to 26 in 36a4445

 // TODO create error handling types 

 // BODY use types like stationExist for more readable and relyable checks 

 if err := a.AddStation(stationID); err != nil && !strings.Contains(err.Error(), "exist") { 

 return err 

 }

This issue was generated by todo based on a `TODO` comment in `36a4445`. It's been assigned to @amitlevy21 because they committed the code.

Integrate GTFS

https://github.com/MobilityData/gtfs-realtime-bindings/tree/master/golang
https://transit.land/documentation/datastore/api-endpoints.html

Add NewStation function to unsure unique id

lets-go/ride/station.go

Lines 11 to 14 in 36a4445

 // TODO Add NewStation function to unsure unique id 

 type Station struct { 

 id int64 

 location coordinates

This issue was generated by todo based on a `TODO` comment in `36a4445`. It's been assigned to @amitlevy21 because they committed the code.

Refactor to packages

Currently, everything is in the same package - main.
The PR would decide which files should go together, hiding unexported fields from others.

Almost every file has a struct with id field with type of int64.
For modularity, consistence and readability there should be a unified type id that will hide the fact we are talking about int64 or any basic type.

amitlevy21 / lets-go Goto Github PK

lets-go's People

Contributors

Watchers

lets-go's Issues

Create error handling types

This issue was generated by todo based on a `TODO` comment in `36a4445`. It's been assigned to @amitlevy21 because they committed the code.

Integrate GTFS

Add NewStation function to unsure unique id

This issue was generated by todo based on a `TODO` comment in `36a4445`. It's been assigned to @amitlevy21 because they committed the code.

Refactor to packages

Create unified id type

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	// TODO create error handling types
	// BODY use types like stationExist for more readable and relyable checks
	if err := a.AddStation(stationID); err != nil && !strings.Contains(err.Error(), "exist") {
	return err
	}

	// TODO Add NewStation function to unsure unique id
	type Station struct {
	id int64
	location coordinates

amitlevy21 / lets-go Goto Github PK

lets-go's People

Contributors

Watchers

lets-go's Issues

This issue was generated by todo based on a TODO comment in 36a4445. It's been assigned to @amitlevy21 because they committed the code.

This issue was generated by todo based on a TODO comment in 36a4445. It's been assigned to @amitlevy21 because they committed the code.

Recommend Projects

Recommend Topics

Recommend Org

This issue was generated by todo based on a `TODO` comment in `36a4445`. It's been assigned to @amitlevy21 because they committed the code.

This issue was generated by todo based on a `TODO` comment in `36a4445`. It's been assigned to @amitlevy21 because they committed the code.