amiga-mui / thebar Goto Github PK

Hello,

I'm posting this issues as I came across incompatibility in AROS when using TheButton. In essence, one click on a button, causes two events to be fired, because first Area class event handler is invoked directly via event handler node registration on Area class and then the same event handler is called via DoSuperMethodA in TheButton class event handler. Effect is button being pressed and then unpressed on AROS. Looking at MUI documentation about MUIM_HandleEvent it says:

"Do NOT pass this method to your superclass by calling DoSuperMethod(). This method is meant for your class only. If your superclass wants to handle certain input events it MUST install an event handler itself."

I also checked with MUI 3.8 on m68k that Area class handler is NOT eating the click event, which means the behavior I described above on AROS is "correct" with regards to what should be happening taking into account TheButton code. However this should have been seen on other platforms already a long time ago, so I wonder if you can give a hint on what is happening. Is MUI Area HandleEvent method something blocking the second (DoSuperMethod-based) invocation from happening?

Second question: should the code in question be changed not to call super class method?

Trying to set MUIV_TheBar_Attr_Selected state using MUIM_TheBar_NoNotifySetAttr on a button that is part of a mutual exclude group doesn't seem to work. I still get a notification on MUIA_Selected. As a workaround, I've tried to use MUIA_TheBar_Active with MUIA_NoNotify but that didn't do the trick either.

Included demos give an error - unable to open v37
and fail to start.

Older builds eg. from 26.16 work just fine

Creating toolbar buttons with BRFLG_ARGB and BRFLG_AlphaMask looks quite ugly on OS3. On OS4 it's looking correctly. Just compare the two images:

Currently, TheBar.mcc is using a pretty awkward and non-standard way of enforcing absolute prioritization of user preferences over individual application requirements. For example, setting MUIA_TheBar_ViewMode to MUIV_TheBar_ViewMode_Gfx during object creation doesn't have any effect at all. TheBar simply ignores it and uses the user's preferences instead.

The only way to override this is to set MUIA_TheBar_IgnoreAppearance to TRUE. But this is some kind of master reset because it completely drops all user settings and resets them to default values. Thus, it is currently impossible to change a single user setting to a hardcoded one without going back to factory settings altogether, i.e. it's not possible to enforce an icon-only toolbar without doing a hard reset using MUIA_TheBar_IgnoreAppearance.

I think this needs a more elegant solution because the current one is not very useful.

Here is another example: Say an app wants to use MUIA_TheBar_MouseOver. According to the docs, this only works with either MUIA_TheBar_Raised or MUIA_TheBar_Sunny set to TRUE. However, the latter two are user settings once again and apps cannot override them without doing a master reset using MUIA_TheBar_IgnoreAppearance. So apps can't really use MUIA_TheBar_MouseOver with the user's settings at all because you don't know whether or not the user has SUNNY or RAISED enabled. It's all pretty messed up IMHO and needs some better design.

When creating a toolbar which doesn't specify separate images for disabled buttons, the standard "graying out" algorithm used by TheBar doesn't look so attractive. See here:

IMHO it would be nicer to use a different algorithm that converts the icon to grayscale or something like that. The current algorithm doesn't look so nice for alphachannel images. It was probably designed for palette based graphics.

TheBar MCC could provide a sort of internal wrapper in order to support the older ToolBar MCC class and functionalities

Original report here:
https://muidev.de/ticket/454

Is there an attribute that is set whenever the mouse pointer is over a toolbar button? I see that there is MUIA_TheBar_MouseOver but it only works with the "Raised" and "Sunny" styles. I'd like to have an attribute that works with all styles. Practical use: I want to display extended help information in a status bar for every toolbar button. I know there is tooltip help for the individual buttons but I'd like to display help texts in the status bar too so I need to find a way to get notified when the mouse pointer is over a toolbar button.

They are not supported in OS3 or MorphOS...