Size of push constants are not checked against layouts? about rendy HOT 5 CLOSED

As you may noticed encoder.push_constants takes raw gfx-hal's PipelineLayout and rendy can't query for it's structure.
We would have to write PipelineLayout wrapper that saves CreateInfo for us to inspect.

from rendy.

Oh shoot, you're right. The info I want is in rendy::graph::render::Layout. Let me look more at how that is related to PipelineLayout, if at all.

from rendy.

For my own reference: SimpleGraphicsPipelineDesc::layout() is called in the RenderGroupDesc::build() impl for it, which calls gfx-hal's Device::create_pipeline_layout. So yes, unless we store the information elsewhere and/or make a way for the Draw method to get its hands on the original Layout, we can't do this in rendy itself.

Vulkan's whole point is that it can assume that the data layout you give it matches the data you give it, and doesn't offer many ways to enforce that. It's up to the user to make sure that's correct. And if rendy is to remain a thin layer over gfx-hal we don't want to go through a whole lot of work enforcing that the data matches what it should; we can do it when it's easy but adding a whole bunch of wrappers for bounds-checking and stuff doesn't sound like what we want.

I'll keep thinking about this and maybe try to come up with an easy way to do the bounds-checking in my own code. Up to you if you want to close this issue.

Edit: Maybe EncoderCommon::push_constants should be unsafe, to indicate it does no bounds checking?

from rendy.

Maybe this should be closed ? (#165)

from rendy.

I guess so

from rendy.