Comments (5)
As you may noticed encoder.push_constants
takes raw gfx-hal
's PipelineLayout
and rendy can't query for it's structure.
We would have to write PipelineLayout
wrapper that saves CreateInfo
for us to inspect.
from rendy.
Oh shoot, you're right. The info I want is in rendy::graph::render::Layout
. Let me look more at how that is related to PipelineLayout
, if at all.
from rendy.
For my own reference: SimpleGraphicsPipelineDesc::layout()
is called in the RenderGroupDesc::build()
impl for it, which calls gfx-hal
's Device::create_pipeline_layout
. So yes, unless we store the information elsewhere and/or make a way for the Draw
method to get its hands on the original Layout
, we can't do this in rendy itself.
Vulkan's whole point is that it can assume that the data layout you give it matches the data you give it, and doesn't offer many ways to enforce that. It's up to the user to make sure that's correct. And if rendy is to remain a thin layer over gfx-hal
we don't want to go through a whole lot of work enforcing that the data matches what it should; we can do it when it's easy but adding a whole bunch of wrappers for bounds-checking and stuff doesn't sound like what we want.
I'll keep thinking about this and maybe try to come up with an easy way to do the bounds-checking in my own code. Up to you if you want to close this issue.
Edit: Maybe EncoderCommon::push_constants
should be unsafe
, to indicate it does no bounds checking?
from rendy.
Maybe this should be closed ? (#165)
from rendy.
I guess so
from rendy.
Related Issues (20)
- Building issues HOT 1
- Issue with triangle example HOT 1
- [Q] How to enable a rendering backend for project? HOT 10
- Can't run triangle example on MAC with metal backend HOT 6
- Issues with the triangle example and vulkan on windows HOT 8
- shader reflection BindingsMismatch if using a binding in one shader not used by other shaders of the same shader program. HOT 1
- Generate vertex tangents for OBJ files HOT 1
- Using LinearAllocator for non-CPU-visible memory HOT 1
- Using DynamicAllocator for large allocations HOT 2
- Image count not supported HOT 2
- Port to gfx-hal-0.5 HOT 2
- MeshBuilder::with_prim_type does nothing HOT 2
- Render pass with no attachments causes subtraction underflow. HOT 1
- missing depth_stencil on SimpleGraphicsPipelineDesc causes crashes HOT 4
- Is this project abandoned? HOT 5
- Add examples folder HOT 2
- PresentMode isn't configurable (aka Rendy forces vsync)
- [MAINTENANCE] post build timings to PRs
- upgrade gfx to 0.6 to fix MacOS
- Unsound type casting in `cast_slice` HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rendy.