Git Product home page Git Product logo

Comments (4)

zakarumych avatar zakarumych commented on August 28, 2024

resource::Kind is gfx_hal::image::Kind reexported.
Shouldn't be that way.

from rendy.

icefoxen avatar icefoxen commented on August 28, 2024

SamplerInfo and ViewKind are also part of gfx-hal. Will submit enhancements to them.

Mesh can't be Clone because it contains a Buffer and IndexBuffer, which need destruction via free_buffers() or whatever. Might be convenient to add a method that creates a copy of a mesh anyway, even if it has to take a queue and factory to do it. ...that said you can't really modify an existing mesh, so why would you want an exact copy of it instead of just reusing it? Maybe to make resource management easier. Same goes for Image; it can't be Clone 'cause it contains GPU-managed data, but being able to make a copy or near-copy of an existing image might be handy.

Actually, Mesh contains Escape<Buffer<B>> but just IndexBuffer<B>. Should the index buffer be wrapped in an Escape too? Looks like it, or its underlying Buffer, could be.

from rendy.

zakarumych avatar zakarumych commented on August 28, 2024

IndexBuffer is just Escape<Buffer<B>> + IndexType.

I can't see use case for copying meshes and images, but it can be easy implemented as stand-alone function. Although stand-alone function suffers from bad discoverability.

from rendy.

icefoxen avatar icefoxen commented on August 28, 2024

Derp, I could have sworn that I saw IndexBuffer containing just a Buffer<B> with no Escape.
Okay, I think that's all. Thank you!

from rendy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.