amethyst-framework / amethyst Goto Github PK

module My::Webapp
  class LoginController < Base::Controller
    actions :index

    view "login", "#{__DIR__}/views"
    def index
      respond_to do |format|
        format.html { render "login"}
      end
    end
end

Will get ERROR: Missing hash value: "LoginController" when trying to GET /login/index

I am very new to Crystal and I tried to run the example project stated in the documentation. It seems that their are out of date. I think it they should be removed from the readme.

I'd like to use this project because it seems to have one of more advanced ORMs for crystal but it looks sort of abandoned. Also I'm having issues getting it to compile with newer versions of crystal. Any suggestions?

We need to add some option to "run in the background".

we can use fork

fork do
  app.serve
end

or some internal design to this this thing.

Here the status code is allowed to be nil, causing the compiler to complain:

in ./libs/amethyst/amethyst/base/handler.cr:12: instantiating 'Amethyst::Http::Response#build()'
        response.build
                 ^~~~~
in ./libs/amethyst/amethyst/http/response.cr:23: instantiating 'HTTP::Response:Class#new((Nil | Int32), String, HTTP::Headers)'
        return HTTP::Response.new(@status, @body, headers = @headers)
                              ^~~
instantiating 'HTTP::Response#initialize((Nil | Int32), String, HTTP::Headers, Nil, String, Nil)'
in /Users/giorgio/Documents/crystal/src/http/response.cr:14: instantiating 'HTTP::Response:Class#mandatory_body?((Nil | Int32))'
    if Response.mandatory_body?(@status_code)
                ^~~~~~~~~~~~~~~
in /Users/giorgio/Documents/crystal/src/http/response.cr:77: undefined method '/' for Nil (compile-time type is (Nil | Int32))
    !(status_code / 100 == 1 || status_code == 204 || status_code == 304)

Either Http::Response.new should not allow a nil status code, or Http::Response.build should check for that and use a "default" one.

Right now, the best OpenSSL lib is @datanoise repo at https://github.com/datanoise/openssl.cr .
Crystals SSL binding are half finished until this will be PRed.

I know Amethyst is using Crystal's HTTP server, the question is what kind of SSL support does the server has ? maybe we should wait for openssl.cr to be merged before adding an SSL option ?

Anyway, SSL can be implemented in a few ways.

1. As part of HTTP::Server, then you just need to allow the user to specify :ssl = true or something in the .serve method.

2. You can bypass HTTP::Server and allow the user to pass down a SSLSocket for you to use (this means the user will need to get from you a TCPSocket and upgrade it using OpenSSL::Context etc...

3. You can implement some kind of Middleware to handle the SSLSocket upgrade.

From those three, I guess 1 is the easiest, but not sure when this is going to happen, this also depends on a) @datanoise, b) @asterite, then you :)

Hello,

I just saw on http://codcore.github.io/Amethyst/ and README.md of this repository that contributor link has not been edited. When I was click on "Andrew Yaroshuk", it will be directed on Github 404 Page Not Found. Link is missing (https://github.com/[your-github-name]).

By the way, thank you for creating Amethyst. Keep up the good work!

Should respond with a 404

Now getting:

ERROR: Action '' not found in controller 'LoginController'

*Amethyst::Exceptions::ControllerException@Exception#initialize<Amethyst::Exceptions::ControllerActionNotFound, String>:Array(String) +46 [0]
*Amethyst::Exceptions::ControllerActionNotFound#initialize<Amethyst::Exceptions::ControllerActionNotFound, String, String>:Array(String) +130 [0]
*Amethyst::Exceptions::ControllerActionNotFound::new<String, String>:Amethyst::Exceptions::ControllerActionNotFound +102 [0]
*LoginController@Amethyst::Base::Controller#call_action<LoginController, String>:Amethyst::Http::Response +52 [0]
*Amethyst::Dispatch::Router#process_default_route<Amethyst::Dispatch::Router, Amethyst::Http::Request, Amethyst::Http::Response>:Amethyst::Http::Response +472 [0]
*Amethyst::Dispatch::Router#call<Amethyst::Dispatch::Router, Amethyst::Http::Request>:Amethyst::Http::Response +149 [0]
*Amethyst::Middleware::Static#call<Amethyst::Middleware::Static, Amethyst::Http::Request>:Amethyst::Http::Response +219 [0]
*Amethyst::Middleware::TimeLogger#call<Amethyst::Middleware::TimeLogger, Amethyst::Http::Request>:Amethyst::Http::Response +466 [0]
*Amethyst::Middleware::HttpLogger#call<Amethyst::Middleware::HttpLogger, Amethyst::Http::Request>:Amethyst::Http::Response +530 [0]
*Amethyst::Middleware::ShowExceptions#call<Amethyst::Middleware::ShowExceptions, Amethyst::Http::Request>:Amethyst::Http::Response +394 [0]
*Amethyst::Base::Handler#call<Amethyst::Base::Handler, HTTP::Request>:HTTP::Response +227 [0]
*HTTP::Server#handle_client<HTTP::Server, TCPSocket+>:Nil +266 [0]
~fun_literal_20 +29 [0]
*Fiber#run<Fiber>:(Nil | Void) +256 [0]
~fun_literal_3 +17 [0]
co_exit +75 [0]
__start_context +0 [0]

Several breaking changes in 0.7.7

Cannot require inside modules or classes anymore.

So, I'm probably doing something wrong, but I have a before_action :authorize in my controller and it doesn't seem to call the def authorize method.

I see the macros defined in the controllers for before_action. Any idea's?

Though the actual error might be "can't run methods on objects in templates".

# Controller
class MyController < Base::Controller
  actions :index

  view "index", "#{__DIR__}/../views/ragas"
  def index
    @array = [1,2,3]

    render "index"
  end
end

# index.ecr
<%= array.length %>

Error:

Error: instance variable '@array' of MyController was not initialized in all of the 'initialize' methods, rendering it nilable

Though if I just have <%= array %> in the view that compiles and renders just fine...

What's up?

Hi to all members of crystal-community! I am an creator of Amethyst framework, and I passed it to crystal-community in hope that here this project will be develop. But, as I see there are no changes to the project and it seems dead. I I demand to return it to my hands, I have people that want to take care of this project.

Hi!

First of all, I'm really liking your web framework! I just tried it (with a small fix) and it looks nice. It looks compact to write and has some things that made me stop and think "wait, how did he do that?".

I tried the example from the README and doing require "amethyst" didn't work, it can't find the view macro. Doing require "amethyst/all" did work, though, but that's not what the example says.

Right now I got this configuration inside a Controller class:

  before_action :authorized?, only: [:r_start, :r_stop, :z_start, :z_stop, :new, :new_rule, :list_rules]

This should call

def authorized?
    puts "Checking User"
    if $cookie_jar.includes?(request.cookies[".rsa"])
      puts "Sending OK"
      response.set(200, "OK")
    else
      puts "Sending Forbidden"
      response.set(403, "Forbidden")
      html "<p>Page cannot be accessed by unauthenticated users</p>"
    end
  end

Now, running the application I can see that the string "Sending Forbidden" is being reached:

[Amethyst 0.1.3] serving application "rsaccess-web" at http://127.0.0.1:8080
Checking User
Sending Forbidden
Checking User
Sending Forbidden

But, the user is getting to the method behind without receiving the correct response

      response.set(403, "Forbidden")
      html "<p>Page cannot be accessed by unauthenticated users</p>"

in this case:

module SomeModule
   class DictController < Base::Controller
     ...
   end
end


include SomeModule

...
get "/dict_index", "dict#index"   =>  Route.new("dict_index", "DictController",  "index")
register DictController  =>         @controllers_instances["SomeModule::DictController"] = SomeModule::DictController
...

When process named route, the "controller key" can't match

This discussion thread might be very interesting to you :-)

Seems like it's been a little while....just wanted to see if this project is still active.

You can define inherited hook on base controller. Example:

http://play.crystal-lang.org/#/r/7kn

all the hooks can be found in this spec: https://github.com/manastech/crystal/blob/119ccc89065165bc937b3417e5ac2af2bab6e056/spec/compiler/codegen/hooks_spec.cr

https://github.com/Codcore/Amethyst/blob/master/src/amethyst/sugar/view.cr

macro view(name, path=__DIR__, *args)
      class MyView < View
        def initialize(
          {% for arg in args %}
            @{{arg.id}},
          {% end %})
        end
        ecr_file "{{path.id}}/{{name.id}}.ecr"
      end
    end

should be

macro view(name, path=__DIR__, *args)
      class {{name.id}}View < View
        def initialize(
          {% for arg in args %}
            @{{arg.id}},
          {% end %})
        end
        ecr_file "{{path.id}}/{{name.id}}.ecr"
      end
    end
``` ???

example:

actions :r_stop

will result in an action named "r" without the _stop.

ERROR: Action 'r' not found in controller 'LoginController'

*LoginController@Amethyst::Base::Controller#call_action<LoginController, String>:Amethyst::Http::Response +753 [0]
*Amethyst::Dispatch::Router#call<Amethyst::Dispatch::Router, Amethyst::Http::Request>:Amethyst::Http::Response +1335 [0]
*Amethyst::Middleware::TimeLogger#call<Amethyst::Middleware::TimeLogger, Amethyst::Http::Request>:Amethyst::Http::Response +5552 [0]
*Amethyst::Middleware::HttpLogger#call<Amethyst::Middleware::HttpLogger, Amethyst::Http::Request>:Amethyst::Http::Response +5561 [0]
*Amethyst::Middleware::ShowExceptions#call<Amethyst::Middleware::ShowExceptions, Amethyst::Http::Request>:Amethyst::Http::Response +40 [0]
~fun_literal_20 +3704 [0]
~fun_literal_3 +33 [0]
co_exit +75 [0]
__start_context +0 [0]

working:

actions :rstop

works as intended

Hello,

I just saw http://codcore.github.io/Amethyst/ and README.md of this repository that contributor link has not been changed. When I was click on "Andrew Yaroshuk", it will be directed on Github 404 Page Not Found. Link is missing (https://github.com/[your-github-name]).

By the way, thank you for creating Amethyst. Keep up the good work!

Something like this makes sense to me, but apparently isn't working as I expect (as in allowing only the first method for each vir dir)

routes.draw do
      get "/",       "login#new"
      post "/",      "login#create"
      get "/login",  "login#new"
      post "/login", "login#create"
      register LoginController
end

Is this a bug or this is how it suppose to behave ?

pledgie returns this error, when trying to donate using PayPal:

The email account Receiver not in receive money enabled country is based in a country that isn't enabled to receive payments

The initialize method in Amethyst::Base::App receive two default arguments:

def initialize(app_path= __FILE__, app_type={{@type.name.stringify}})

Here, app_path initialize by "?" because FILE is "?" in default argument of initialize method.
For Example:

class A
  def initialize(@file : String =__FILE__) 
    puts @file
  end
  
  def get(@file=__FILE__) 
    puts @file
  end
end

a = A.new  # => "?"
a.get      # => file_path

So, "initialize should set app name" in spec/base/application_spec.cr is failing.

spec/base/application_spec.cr:

app = Base::App.new

it "should set app name" do
  app.name.should eq "application_spec"  # app.name => "?"
end

One way to solve it is to remove a default argument of app_path.

We need to have more control over logging:

1. Control of output IO (file, STDOUT, STDERR, etc..)
2. Control over format (clear text, Logger, etc..)
3. Control via levels, warn, error, fatal etc ..

Under heavy load using wrk -t 10 -c 300.
I get a Broken pipe error, then even though Amethyst is still running the socket isn't listening anymore.

I'm doing this check:

key = "cookey"
value = Base64.urlsafe_encode64(SecureRandom.random_bytes(128))
unless request.cookies.has_keys? [:cookie]
  response.cookie(key, value, secure=false)
end

And in the client I get this:

ERROR: Missing hash value: "Cookie"

*HTTP::Headers#[]<HTTP::Headers, String>:String +724 [0]
*LoginController#show<LoginController>:String +447 [0]
*LoginController@Amethyst::Base::Controller#call_action<LoginController, String>:Amethyst::Http::Response +62 [0]
*Amethyst::Dispatch::Router#call<Amethyst::Dispatch::Router, Amethyst::Http::Request>:Amethyst::Http::Response +1778 [0]
*Amethyst::Middleware::TimeLogger#call<Amethyst::Middleware::TimeLogger, Amethyst::Http::Request>:Amethyst::Http::Response +5552 [0]
*Amethyst::Middleware::HttpLogger#call<Amethyst::Middleware::HttpLogger, Amethyst::Http::Request>:Amethyst::Http::Response +5593 [0]
*Amethyst::Middleware::ShowExceptions#call<Amethyst::Middleware::ShowExceptions, Amethyst::Http::Request>:Amethyst::Http::Response +40 [0]
~fun_literal_20 +3884 [0]
~fun_literal_3 +33 [0]
co_exit +75 [0]
__start_context +0 [0]

Hi I just wrote a migrations class for postgres that I use in my project https://gist.github.com/solisoft/2476718a494e20dbfcc2

Using Crystal 0.7.3

Cloning the repo and trying to run examples with

crystal run examples/simple_application.cr

Gives the error

Error in ./examples/simple_application.cr:6: while requiring "../src/amethyst"

require "../src/amethyst"
^

in ./src/amethyst.cr:1: while requiring "./amethyst/base"

require "./amethyst/base"
^

in ./src/amethyst/base/base.cr:8: while requiring "../middleware"

require "../middleware"
^

in ./src/amethyst/middleware/middleware.cr:2: while requiring "mime": can't find file 'mime' relative to '/Users/serdardogruyol/playground/Amethyst/src/amethyst/middleware'

require "mime"
^

in line 135 of https://github.com/Codcore/Amethyst/blob/master/src/amethyst/http/request.cr
you have

rescue IndexOutOfBounds

I changed that in my upcoming PR (bararchy@2fd8766) to

rescue IndexError

This is because of PR crystal-lang/crystal#859

Will WebSocket be implemented in the project or should it be handled in middleware ?

The goals of Amethyst are to be fast like Node.js

Being compiled language, Crystal should be faster than Node.js. The goal should be much higher than that.

Am I missed something?

This repository is moved to crystal-community, so build status of this repository is unknown.
Please re-register to Travis CI.

From Amethyst:
Status code: 200 OK HTTP/1.1

From Google:
Status code: 200 OK
Version: HTTP/2.0

Pictures:
Amethyst:

Google:

As there are many other projects named "Amethyst", I thought for a new name for my web framework. Feel free to comment your suggestions!