Git Product home page Git Product logo

amd_hsmp's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

amd_hsmp's Issues

I also get an error w.r.t. copy_struct_from_user() but on RHEL 8.3 (4.18.0-240.el8.x86_64)

# make
make -C /lib/modules/`uname -r`/build M=$PWD modules
make[1]: Entering directory '/usr/src/kernels/4.18.0-240.el8.x86_64'
  CC [M]  /root/downloads/amd_hsmp-master/amd_hsmp.o
/root/downloads/amd_hsmp-master/amd_hsmp.c: In function ‘hsmp_ioctl’:
/root/downloads/amd_hsmp-master/amd_hsmp.c:280:6: error: implicit declaration of function ‘copy_struct_from_user’; did you mean ‘copy_from_user’? [-Werror=implicit-function-declaration]
  if (copy_struct_from_user(&msg, sizeof(msg), arguser, sizeof(struct hsmp_message)))
      ^~~~~~~~~~~~~~~~~~~~~
      copy_from_user
cc1: some warnings being treated as errors
make[2]: *** [scripts/Makefile.build:322: /root/downloads/amd_hsmp-master/amd_hsmp.o] Error 1
make[1]: *** [Makefile:1544: _module_/root/downloads/amd_hsmp-master] Error 2
make[1]: Leaving directory '/usr/src/kernels/4.18.0-240.el8.x86_64'
make: *** [Makefile:16: default] Error 2

Unexpected HSMP register addresses

#define SMN_HSMP_MSG_ID 0x3B10534

These registers triplet is surprisingly working with MATISSE/3950X but not with VERMEER/5900X

The last being part of family 19H to my understanding; we would expect PPR Vol 2 for AMD Family 19h Model 01h B1 to specify the right registers ?

implicit declaration of function ‘copy_struct_from_user’

The latest version (commit 4276242) of the HSMP is not possible to compile because of the following error:

$ make
make -C /lib/modules/`uname -r`/build M=$PWD modules
make[1]: Entering directory `/usr/src/kernels/3.10.0-1160.53.1.el7.x86_64'
CC [M] /apps/all/AMD_hsmp/42762428221d7304dd12ebc9c724952fa5a5d253/amd_hsmp.o
/apps/all/AMD_hsmp/42762428221d7304dd12ebc9c724952fa5a5d253/amd_hsmp.c: In function ‘hsmp_ioctl’:
/apps/all/AMD_hsmp/42762428221d7304dd12ebc9c724952fa5a5d253/amd_hsmp.c:280:2: error: implicit declaration of function ‘copy_struct_from_user’ [-Werror=implicit-function-declaration]
if (copy_struct_from_user(&msg, sizeof(msg), arguser, sizeof(struct hsmp_message)))
^
cc1: some warnings being treated as errors
make[2]: *** [/apps/all/AMD_hsmp/42762428221d7304dd12ebc9c724952fa5a5d253/amd_hsmp.o] Error 1
make[1]: *** [_module_/apps/all/AMD_hsmp/42762428221d7304dd12ebc9c724952fa5a5d253] Error 2
make[1]: Leaving directory `/usr/src/kernels/3.10.0-1160.53.1.el7.x86_64'

$ gcc --version
gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-44)
Copyright (C) 2015 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

versions using ioctl is not possible to insert to the kernel

We have two system using the same CentOS 7 with old kernel (3.10.0-1160.80.1.el7.x86_64). One of the systems works perfectly with the master version of the amd_hsmp, however the other one (2x7763 + 8x A100 per node) fails when inserting the kernel module. It results in the following error:

insmod: ERROR: could not insert module amd_hsmp/4276242/amd_hsmp.ko: No such device

I have tested older versions of the code, and found out that only the very old version without ioctl interface (5d590b2) is possible to insert, and works fine.

Do you have a clue why the ioctl versions do not work? Thanks
@nchatrad

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.