Git Product home page Git Product logo

freshbooks-php-sdk's People

Contributors

actions-user avatar amcintosh avatar dominikb avatar stickler-ci avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

freshbooks-php-sdk's Issues

New Invoice Creation - Quantity

You have the quantity type set to integer which only allows whole numbers

May want to make this a float to allow for partial quantities

Update events resource to handle new error responses

The error response for the events API has changed. The events resource needs to be updated to handle the new error responses. Currently all errors are creating exceptions with "Unknwon error" as the message.

taxNumber1 Issue when creating an Invoice

When creating an invoice - it returns the following error

Write access denied. Tried to write None to field taxNumber1 of object line

Per Freshbooks Support - we aren't supposed to send/try to set taxNumber1 or taxNumber2

What is the support status of this repo?

I see that Freshbooks calls this a community library https://www.freshbooks.com/api/libraries , but note the ReadMe says 'FreshBooks users are uniquely identified by their email across our entire product.' The repo seems to have only a single contributor but to be very professional and actively under development/maintained.

I'd like to use it but don't want to get tied into an abandoned library. What is the status of @amcintosh 's or others' commitment to maintaining and developing this PHP SDK for Freshbooks?

Overriding a single model requires calling createHttpModel() from within the overridden FreshBooksClient, instead of just using $this->httpClient

I needed a client field (username) which the default model doesn't include. It's a deprecated field, so I didn't think it warranted its own pull request.

So I overrode the FreshbBooksClient so I could override the public clients() method and insert a custom model (which extended the base and just added another public property).

The original method looks like this:

   public function clients(): AccountingResource
    {
        return new AccountingResource($this->httpClient, 'users/clients', Client::class, ClientList::class);
    }

$this->httpClient is a private property, so the extension didn't have access to it. I called $this->createHttpClient() in that place, and everything seems to be working perfectly. But it feels like that should maybe be a protected property to make it easier to reuse the same httpClient in my extension.

Anyway this is no big deal. I'm really enjoying the package and it's saving me a lot of time. If you're interested in this change, I could also submit a PR. If you're not interested, that's fine; just go ahead and close this issue.

Thanks so much for this package!

Handle oauth token and refresh token flows

Currently the client handles generating the auth url (getAuthRequestUrl), but doesn't allow for fetching the access token or refreshing a token.

  • Handle the token calls
  • Document in README
  • Throw error if client not properly configured

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.