am-kantox / dry-behaviour Goto Github PK

Check whether the protocol was fully implemented (in the very last line of defimpl handler) and raise or at least warn.

• mark protocols as consolidated one reaching the TracePoint, disallow modifications when consolidated;
• allow annotations @spec[string, user => any | hash]
• implement annotations with aspects, maybe allow aspects

• allow implicit interface inheritance (opt-in)
• deprecate implicit delegation to the target object with a message
• print a deprecation message for ⇑ saying it’ll raise effective 1.0

When the definition of the method has an arity that differs from the implementation we should print the error message to the log and optionally raise.

Hi,

I think invoking methods defined by defmethod/defimpl with keyword arguments is not working correctly on Ruby 3.2.0.

I discovered this while trying to upgrade my app from 2.7 to 3.2 and was able to verify the failure by cloning the repo and running the tests.

Repro:

• Make sure you're using Ruby 3.2.0
• git clone [email protected]:am-kantox/dry-behaviour.git
• cd dry-behavior
• bundle
• bundle exec rspec spec/dry/behaviour_spec.rb

Failure: "works for default and keyword args (FAILED - 1)"
Error: "ArgumentError: wrong number of arguments (given 0, expected 1+)"

I'm seeing the same behavior in my app when trying to invoke a method with a positional and default keyword argument.

I'll see if I can locate the source of the issue and make a PR, but any guidance you can offer would be helpful.

Thanks!