Git Product home page Git Product logo

Comments (3)

alunbestor avatar alunbestor commented on July 23, 2024

The short version: yes, this restriction is still in place for all Boxer versions and yes, I plan to do something about it.

The long version:
As you may have realized, the "Use 4:3 Aspect Ratio" option is really toggling between "Use 4:3 Aspect Ratio" and "Don't apply any aspect ratio correction": not between "Use 4:3 Aspect Ratio" and "Use my display's aspect ratio", as is your intention.

The most common DOS resolution is 320x200, a 16:10 ratio: at this resolution, toggling the option off makes it fill a macbook display (also 16:10) or mostly fill an iMac display (16:10 on older models, 16:9 on newer ones.) As a result of this happy coincidence, toggling the option off seems like it means "Use my display's aspect ratio".

Syndicate Wars runs in 640x480, which is already a 4:3 ratio: hence toggling the option appears to do nothing, because Boxer didn't have to apply any correction in the first place to make it 4:3. Despite being "correct", that clearly is contrary to the expected behaviour of the option.

However, there's a few reasons why it's not a good idea to simply change the meaning of the "off" state of the toggle:

  • "Use my display's aspect ratio" is not particularly meaningful or appropriate in windowed mode, which is Boxer.app's default mode (unlike GOG's games, which default to fullscreen).
  • Many users turn the correction off because the unstretched appearance of 320x200 feels more natural to them. But non-16:10 displays are becoming more and more common, and if off means "use my display's aspect ratio", then users with non-16:10 displays end up with extra stretching whichever mode they choose.

My preferred solution, then, is to make the on/off aspect ratio toggle into a menu of three explicit aspect ratio options (names still to be decided): "Fit to 4:3" (the default), "Fit to display" (your preference) and "Square pixels" (disable aspect ratio correction).


For what it's worth, standalone Boxer apps actually have an option to hide the 4:3 aspect ratio menu option altogether for games where it won't do anything - like Syndicate Wars. In this case GOG forgot to toggle that option, or else left it in for use with Syndicate Wars's low-resolution mode.

from boxer.

RR7 avatar RR7 commented on July 23, 2024

cheers Alun, for me its all about it just working and hiding or dealing with all the 'option' automagically. its the mac way, and you're doing a great job.

from boxer.

alunbestor avatar alunbestor commented on July 23, 2024

For me too most of the time, but in cases like this there's clearly more than one right answer (and more than one set of expectations at work), so it's better to be a little more complex but explicit about the behaviour.

from boxer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.