aludwiko / fluentbuilder Goto Github PK

View Code? Open in Web Editor NEW

2.0 2.0 3.0 370 KB

License: Other

Java 100.00%

fluentbuilder's People

Contributors

Stargazers

Watchers

Forkers

bluecarat mpochwala athlan

fluentbuilder's Issues

printsticCreateMethod

custome method prefix problem

ignoring fields by regexp

retention policy to source

support for inheritance

builders should be able to initialize inherited fields

Unused imports

In some cases builder generates unused imports which does not comply CheckStyle policy:

import info.ludwikowski.fluentbuilder.common.AbstractBuilder;
import java.util.ArrayList;
import java.util.Arrays; <-- unused
import java.util.Date;
import java.util.List; <-- unused

Unused imports appears when one of attribute is ArrayList<T>

add socomo plugin

support for classes without default constructors

usunąć zależność cykliczną

move builder creation do abstract*builder class

with flag disabling this functionality, for backward compatibility

compiler arguments must be in single line

otherwise processor is not working properly

FLUENT_BUILDER_ANNOTATATION constant with wrong package

duża litera w pakiecie

problems with classes in default packege

create na góre

Invalid generic import and Primitive import while field is required in constructor.

There is a unexpected import while generic parameter is in constructor:

package com.example.model;

import java.util.List;

import info.ludwikowski.fluentbuilder.annotation.GenerateBuilder;

@GenerateBuilder
public class Foo {

    private String var1;
    private List<Bar> var2;

    public Foo(String var1, List<Bar> var2) {
        this.var1 = var1;
        this.var2 = var2;
    }

    public String getVar1() {
        return var1;
    }

    public List<Bar> getVar2() {
        return var2;
    }
}

And generic class definition:

package com.example.model;

public class Bar {

    private String var1;

    public Bar(String var1) {
        this.var1 = var1;
    }

    public String getVar1() {
        return var1;
    }
}

Invalid builder for Foo is generated:

package com.example.model;

import info.ludwikowski.fluentbuilder.common.AbstractBuilderFactory;
import java.util.List<com.example.model.Bar>;


/**
 * Fluent builder for Foo.
 * Don't hesitate to put your custom methods here.
 */
public abstract class FooBudowniczy extends AbstrakcyjnyFooBudowniczy<FooBudowniczy> {

	public static FooBudowniczy foo(String var1, List<Bar> var2){
		return AbstractBuilderFactory.createImplementation(FooBudowniczy.class, var1, var2);
	}
}

In import section the generic parameter is redundant:
import java.util.List<com.example.model.Bar>;

generate builder and abstract builders to 2 diffrent destinations

cqlib dependency should be shaded to avoid class loader issues

remove dependency to spring-core

loggin

private void printBuilderPrinter(ClassMirror classMirror) {

    context.getProcessingEnvironment().getMessager().printMessage(Diagnostic.Kind.NOTE, "test");

    try {

        BuilderPrinter printer = new BuilderPrinter(context, classMirror);


        Filer filer = context.getProcessingEnvironment().getFiler();
        FileObject resource = null;
        try {
            context.getProcessingEnvironment().getMessager().printMessage(Diagnostic.Kind.NOTE, "test1");
            resource = filer.getResource(StandardLocation.SOURCE_OUTPUT,
                    printer.getPackageName(),
                    printer.builderName() + ".java");
            context.getProcessingEnvironment().getMessager().printMessage(Diagnostic.Kind.NOTE, "test2: " + resource.getLastModified());
        }
        catch (Exception e) {

            context.getProcessingEnvironment().getMessager().printMessage(Diagnostic.Kind.ERROR, "Problem with Filer: " + e.getMessage());

        }

        if (resourceNotExists(resource)) {

            context.getProcessingEnvironment().getMessager().printMessage(Diagnostic.Kind.NOTE, "test3");
            FileObject fo = context.getProcessingEnvironment().getFiler()
                    .createSourceFile(printer.getFullClassName());


            OutputStream os = fo.openOutputStream();
            PrintWriter pw = new PrintWriter(os);

            pw.print(printer.printClass());

            pw.flush();
            pw.close();
            context.getProcessingEnvironment().getMessager().printMessage(Diagnostic.Kind.NOTE, "test4");
        }

    } catch (IOException e) {
        context.getProcessingEnvironment().getMessager().printMessage(Diagnostic.Kind.ERROR, "Problem with Filer: " + e.getMessage());
    }
}

private boolean resourceNotExists(FileObject resource) {
    return resource == null || resource.getLastModified() <= 0;
}