alquist42 / querytemplates Goto Github PK

Report from Andreas Kalsch.

Following code from "output.code.php" causes "Fatal error: Cannot use object 
of type stdClass as array".

$d = new stdclass;
$d->a = 1;
var_dump(isset($d['a']));

Solution:

if (is_array($data) && isset($data['objs'])) $__242d2 = $data['objs']; else 
if (isset($data->{'objs'})) $__242d2 = $data->{'objs'}; 

Static loop support.

$t['>ul > li']->valuesToLoop($d, function($row, $li1) {
    $node->valuesToSelector($row['User'], 'span.%k')->
        find('> ul')->
            valuesToLoop($row['Tags'], function($tag, $li2) {
                $li2->valuesToSelector($tag);
            })
    ;
});

printVar support multiple var
first non-empty var is printed

Port QT to other languages. First will be JS. Ruby and python are considered.

pqt() shortcut to pq(), to easily wrap DOMNodes into QueryTemplates objects
(additional methods available).

Addign JSON input for template using one-line script.

Should support:
- passing thou pipe
- passing as parameter
-- more than one variable

What steps will reproduce the problem?
1.
find('div.comments')->ifVar('is_entry')

we have a var in context $in_entry=false

..not to show comments on index pages


What is the expected output? What do you see instead?

error in generated php code ... if(is_entry...)
instead of if($is_entry)...

workaround here is to use find('div.comments')->ifVar('$is_entry')

What version of the product are you using? On what operating system?

latest

Please provide any additional information below.

I find it a bit confusing writing variables with or without $, why not make it 
everywhere without the php $ ?

This mode wont need any file write-read, as it would use: 
eval('?>'.$code);

Present JS loops doesn't skip inherited fields and are slower for arrays 
than they can be.

Todo:
 * use hasOwnProperty
 * use classic "for" loop for arrays

Missing manual pages should be created. Existing checked and finished.

This functionaliy:
->sourceCollect('input.html')  
  ->parse()  
    ->source('input.html')->returnReplace()

Will be equal to:
->parse('input.html')

Then shortest template will be like this:
template('output')->parse('input.html')  
  ->find('.my-div')  
    ->ifVar('showMyDiv')  
    ->find('ul > li')  
      ->loopOne('data', 'row')  
        ->varsToSelector('row', $rowFields)  
; 

What steps will reproduce the problem? Example:

1. $template->varPrintAttr('href', 'row.name')
2. Results in compiled code:
a) PHP: ... <a href="" class="name" row.name="<?php  if
(isset($row['name'])) print $row['name'];
else if (isset($row->{'name'})) print $row->{'name'};  ?>"> ...
b) JavaScript: ... <a href="" class="name" row.name="';
19
20 print(row['name']);
21;
22 __template += '"> ...

It seems that the documentation says, that
1) the first arg is the attribute's name,
2) and the second arg is the var name

When using paths to access the data tree, it is possible in PHP that some
are arrays and some are objects, so there must be made a distinction
between more than 2 cases in the compiled script. This is how it currently
looks like for "varPrint('data.foo.bar.0')"

<div>
     <p><?php  if (isset($data['foo']['bar']['0'])) print
$data['foo']['bar']['0'];
 else if (isset($data->{'foo'}->{'bar'}->{'0'})) print
$data->{'foo'}->{'bar'}->{'0'};  ?></p>
 </div>


Solution:

function find ($object, array $path) {

    if (!$path) return $object;

    $next = array_shift($path);

    if (is_array($object)) return isset($object[$next]) ? find($object[$next],
$path) : null;
    elseif (is_object($object)) return isset($object->$next) ?
find($object->$next, $path) : null;
    else return $object;
}

$a = array();
$a[]=array();
$a[0]['OK'] = new stdclass;
$a[0]['OK']->test = 0;
$a[0]['OK']->c = 1;

var_dump(find($a, array(0, 'OK', 'c', 'a')));


And now it looks like: 

<div>
     <p><?php print(find($data, array('foo', 'bar', '0'))); ?></p>
</div>

Allowing to include templates on both client and server sided with no need
for a markup change.

When template is actively cached (void object is returned to simulate the
chain), toReference() doesn't change passed variable. This can lead up to
"Call to a member function ... on a non-object". Thus toReference called on
void object should also return void object.

->ifVar('va1', 'var2')
->elseIfVar('va1', 'var2')

applies also to ifNotVar, elseIfNotVar

JS generator undefined checks are wrong:

typeof $var != undefined

Should be 

$var !== undefined

Values are just inserted plain text into the markup. This adds security issues.
To just escape object properties beforehand is possible, but I don't want
to use an own object just for templating (think of encoding the object to
JSON in the next step)

So what about adding extra methods or an additional argument to define, if
a value's special chars should be encoded?

Support callbacks in template filling methods

eg need to remove field's class name from node, after injecting data

$callbackRemoveClass = new Callback(
  create_function('$node, $fieldName', 'pq($node)->removeClass($fieldName);')
);
...->varsToSelector('variable', $fields, null, $callbackRemoveClass)->...

Formatter should properly intend final code. There are already HTML Tidy
and XML_Beautifier integrations, but those have issues. Either this issues
will be solved or formatting in DOMDocument level will be achieved.

Rapid table creation.

Generate template in other languages. First will be JS. Ruby is considered.

Support array fields in data injecting methods. By array fields i mean
ending with '[]' and creating array on the server side.

eg:
->varsFilter('htmlentities', 'stripslashes')

Applies callbacked filters to each variable injection.
Support last boolean parameter to switch 'sticky filter'.

->ifCodeContinue($code)
->ifCodeBreak($code)

Collection of QueryTemplates and jQuery-like patterns useful when dealing
with templates. Best place is probably the wiki.

Additional suffixes: after, before, append, prepend; eg varsToSelectorPrepend()

Light version will contain all valuesTo and formFromValues methods types
and will be implemented as jQuery plugin.

CSS stylesheet support can be used for Event Delegation directly from the
stylesheet to specially prepared methods. Simple mockup:

#browser.ie4 div.contents .section:load {
  stripTables: "odd-tr";
  modifySection: 10 arg1 "argument 2";
}

In this example selector is root for delegation with event stated at the
end. Properties are methods (what would class looks like ? :: ?) and
parameters are method's parameters, separated by space.

Additionally above example contains some browsercheck, which illustrates
another usecase for such functionality.

Probably best tool for this will be CSSTidy[1] with native PHP
implementation. Other possibility is PEAR class. Own implementation is also
considered.

[1] http://csstidy.sourceforge.net/

unsets all var at the end of template
implement in language class

Actual cache method (1.0 beta2) caches only internal QueryTemplates code
and supplied callbacks. Every code executed before going into template
chain is executed always, also when template is read from cache. That's why
new cache method should be available to target this issue. Consider
following code:

require templateFile('my-template-formula.php', __FILE__);

Unfortunately this would NOT work with $monitorCodeModification and
$monitorSourceModification, only with $cacheTimeout. __FILE__ is needed for
determining templates path. 

support quoting var names to not be quoted as strings ex
  'obj.param.`scopeVar`.subkey'
would became
  $obj->param->{$scopeVar}->subkey;

Cascade-inherited filter declaration:

$dom['div']->varsFilter('htmlentities', 'stripslashes');
$dom['div p']->varPrint('foo');

Would result in:

<div>
  <p><?php print htmlentities(stripslashes($foo)); ?></p>
</div>

->valuesToLoopReference($data, $referenceArray)
foreach($referenceArray as $r) {
  $record = $r[0];
  $node = $r[1];
}

->ifVarIsset('var.name')
->ifVarNotIsset('var.name')
->elseIfVarIsset
->elseIfNotVarIsset

template('mandatory-name')->
  pq("<form/>")->
    attr('id', 'my-id')
;