alpac-4 / auto_repay Goto Github PK

Hi. I was wondering if you have a plan to update transaction code to support columbus 5? Currently the transaction code doesn't seem to work.

in index.js

lines 563 to566

        }else if(nowPercent < **belowTrigger**){
            let ust_amount = parseInt((target_percent - percentNow) / percentNow * loanAmount)
            await repayHandler.borrow_ust(ust_amount)
        }

should this be target_percent, as belowTrigger is always -1 and is not the target value

        }else if(nowPercent < **target_percent**){
            let ust_amount = parseInt((target_percent - percentNow) / percentNow * loanAmount)
            await repayHandler.borrow_ust(ust_amount)
        }

I just spent more than an hour trying to make the script able to run from just npm start and if there isn't a mnemonic on the .env, it'll prompt the user.
Unfortunately, I just couldn't get it to work, possibly because I'm rather new to NodeJS.
I believe someone experienced can handle such an easy feature in just a few minutes.

The idea/reason is simple:

• .env isn't very safe, as has already been started;
• giving the seed phrase as a process argument isn't that much better since most users won't know they should put a (space) before npm start so that the phrase isn't recorded on the command line history...
• by checking if the mnemonic is empty, it should prompt the user for it; this way it's not stored anywhere but the machine's memory (RAM), and we could potentially do process.stdout.write('\033c'); to clear the console (so it's also not visible by scrolling).

Awesome project !

Thank you so much for doing this.

I did start something in python using anchor and mirror CLI. I wish both had a python SDK for simplicity !!

Anyways, what is the need for "fs": "0.0.1-security" ? in pks dependence ? Is it really required ?

https://www.npmjs.com/package/fs

I'm not too familiar with nodejs.

Ty

Occasionally the program stops (I think) by itself.
It's weird, but looks like it's still printing empty lines or something, in the background, since as you can see from the bottom half, it's just empty... (no, it wasn't me pressing Enter or something).