allynfolksjr / spree_vouchers Goto Github PK

If an order totals $50, and the gift card has $30 left, the admin backend will by default drain the voucher and then charge the user the full $50 instead of $20.

Flash messages wrt ajax "Use a Voucher" functionality often incorrectly display on next visited page, after already displaying on the current page.

Is this needed? What would it look like?

At minimum, a display of recently used giftcards would be required.

I was able to replicate this earlier; unable now. Watch for when issue resurfaces again.

On the admin backend, if you cancel a voucher capture, you can still "void" this voucher transactions, which will result in a credit a user may have already received.

This will cause the authorized_amount to turn into a negative value, which will result in multiple other issues, including letting a user appear to be able to use voucher for more than its actual value. However, when an admin attempts to capture voucher, this will fail with an authorized/total mismatch.

Even if a user enters a valid voucher that will cover 100% of price, store will still require them to enter in another form of payment as well.

Likely want to store temporary copies of giftcards locally, but use Valutec's API for all transactional logic and make appropriate calls to ensure integrity.

Card information is required to be added again, using an existing CC will result in an error.

NoMethodError at /checkout/update/payment
undefined method `first' for nil:NilClass

NoMethodError at /checkout/update/payment
undefined method `first' for nil:NilClass