allalgorithms / cpp Goto Github PK

Since we are a small team reviewing pull requests, we are looking a C++ maintainer to resolve the Outstanding pull requests:

Requirements:

• At least 6 months on Github (Experience reviewing code, etc..)
• Previous C++ Knowledge.
• Decided to review and work on issues at least every 3 days.
• Open source enthusiast
• Previus algorithms knowledege.
• Must start this project :)

How to apply? Please Join our Gitter Chat, and let me know in private or here!

This issue is:

• A new Algorithm
• An update to an existing algorithm.
• An error found
• A proposal
• A question
• Other (Describe below*)

Description:

Hi, everyone!

Do you know any algorithm implementation in any language, that you wanna share with us?

Open a pull request in any of the programming languages available, or in C Plus Plus this case

I am creating an issue because I have made a PR for the addition of a new algorithm- Create Reverse LinkedList file #349
Hope you will like it and merge with the repo. Thank you!

Hi, everyone!

Do you know any algorithm implementation in any language, that you wanna share with us?

Open a pull request in any of the programming languages available, or in C Plus Plus this case

I am creating an issue because...
I want to contribute on it. Kindly assign this task to me.

This project is awesome!. Looking more on Rust based problems too!

I would love to work on this repository. Are you still open to accept pull requests?

I am creating an issue, to contribute the algorithm of Merge sort.
I will be contributing Mergesort code under well defined and professional Manners.

According to AllAlgorithms/python#32 (comment)

Hi @Zxey I liked, but it seems that the algorithm isn't properly implemented.

According to this the following gif:

From 1-100 the lucky numbers should be:

1, 3, 7, 9, 13, 15, 21, 25, 31, 33, 37, 43, 49, 51, 63, 67, 69, 73, 75, 79, 87, 93, 99

This is the link to your implementation repl.it/@abranhe/lucky-numbers-in-python online, I just set the range from 1 - 100.

In a part of the output you will see:

number 17 is not lucky
number 18 is not lucky
number 19 is lucky
number 20 is not lucky
number 21 is not lucky
number 22 is not lucky
number 23 is not lucky
number 24 is not lucky
number 25 is not lucky
number 26 is not lucky
number 27 is lucky
number 28 is not lucky

Where they don't match with the output it should be:

Eg:

• 19 isn't lucky
• 25 is lucky
• 27 isn't lucky
• and so on ...

So this need to be fixed to be merged, I am creating an issue right now, hopefuly we will implement correctly.

After finding this issue on Python I went back again to C++ to double check if the algorithm was ok, but cpp/lucky numbers doesn’t seem right at all.

We need to find the a correct implementation for Lucky Numbers!

I am creating an issue because...
There is only iterative codes for Dynamic programming.
It would be good to add Memoization (top down) approach as well

I am creating an issue because... The directory algorithms/data-structures/LinkedList does not cover all the linked list types. I want to contribute. I will add codes for all the linked List types Singly(Linear and Circular) and Doubly(Linear and Circular) Linked List.

Detailed Description

Link of the file: https://github.com/AllAlgorithms/cpp/blob/master/algorithms/dsu

Context

in all files of dsu, the "find_parent" method is inefficient.

Possible Implementation

We can implement by loop instead of recursion to avoid unnecessary stack and function overhead.

The creation and testing of each algorithm, should be included on was his language repository

This issue is:
Algorithm for N'th Fibonacci number in logarithmic time.

• A new Algorithm
• An update to an existing algorithm.
• An error found
• A proposal
• A question
• Other (Describe below*)

Description:
Write an Algorithm for N'th Fibonacci number in logarithmic time.

This issue is:

• A new Algorithm
• An update to an existing algorithm.
• A proposal

see #233 pull reques