Git Product home page Git Product logo

instruction-level-mips-simulator's People

Contributors

alighorab avatar

Stargazers

 avatar  avatar  avatar  avatar

Watchers

 avatar

Forkers

karry06

instruction-level-mips-simulator's Issues

Issues about arithmetic functions implemented in "instr.c"

Such a code snippet in line 69:

void add(uint8_t rs, uint8_t rt, uint8_t rd) {
   if(rd != 0) {
    NEXT_STATE.REGS[rd] = CURRENT_STATE.REGS[rs] + CURRENT_STATE.REGS[rt];
  }
}

For overflow, I think the code can be improved with:

void add(State& mips_state, uint32_t rs, uint32_t rt, uint32_t rd){
  int32_t temp1 = mips_state.reg[rs];
  int32_t temp2 = mips_state.reg[rt];
  int32_t result = temp1 + temp2;
  if (((temp1 < 0 ) && (temp2 < 0) && (result >= 0)) || ((temp1 > 0) && (temp2 > 0) && (result <= 0))){
    throw (static_cast<int>(Exception::ARITHMETIC));
  }
  else {
    mips_state.reg[rd] = temp1 + temp2;
  }
  ++mips_state.npc;
}

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.