Anonymous namespaces opening bracket removed after using -fix about o2codechecker HOT 11 OPEN

Thanks for this report.
@ZdravkoD : Can you please take a look into this bug report?

Please note that the namespace check is development is progress. Please disable it for the moment. The only checks in production are the ones listed in the o2checkcode.sh recipe.
We might have to go to a real release model ... now that people are starting to use the checks -:)

from o2codechecker.

@PascalBoeschoten: I merged an improved namespace checker. Would you mind trying it out and seeing if the bug is solved?

from o2codechecker.

If I run

run_O2CodeChecker.py -clang-tidy-binary `which O2codecheck` -checks=-*,aliceO2-namespace-naming -fix

it doesn't seem to find/change anything, even though my namespace names are camelcase. But it also doesn't break anonymous namespaces anymore.

from o2codechecker.

@PascalBoeschoten Can you try running O2codecheck --list-checks --checks="alice*" and check if aliceO2-namespace-naming appears in the list? The command that you gave runs fine and finds namespace errors when I run it at ~/alice/sw/BUILD/O2-latest/O2/.

from o2codechecker.

It appears in the list.
The command I gave also lists only aliceO2-namespace-naming as check (others are all disabled)

$> run_O2CodeChecker.py -clang-tidy-binary `which O2codecheck` -checks=-*,aliceO2-namespace-naming -fix
Enabled checks:
    aliceO2-namespace-naming

from o2codechecker.

@PascalBoeschoten : Ok, I believe I know why this is: We recently needed to added filtering of the source path of the translation unit and we have probably put something with O2 ... not knowing that other repos want to use the tool as well. @ZdravkoD : We need to add configuration of the path from the outside.

from o2codechecker.

@PascalBoeschoten : We now added a configuration possibility to let the tool know which repository it is checking. Can you please add a .clang-tidy file inside your project as mentioned in this commit 642b8f4 and provide the proper regular expression matching your source tree.

Feedback is highly welcome.

from o2codechecker.

@PascalBoeschoten : see also AliceO2Group/AliceO2#583; I checked that this works for O2 and the namespace checks.

from o2codechecker.

So the file would contain something like this?

CheckOptions:
  - key: CheckPathRegex
    value: '.*/ReadoutCard/.*'

from o2codechecker.

@PascalBoeschoten : Yes, that should work if your files are located at a subfolder of ReadoutCard.

from o2codechecker.

Done

from o2codechecker.