Git Product home page Git Product logo

Comments (5)

ktf avatar ktf commented on July 29, 2024

Isn't what I do in:

https://github.com/AliceO2Group/O2CodeChecker/blob/master/aliceO2/MemberNamesCheck.cpp#L62

enough?

from o2codechecker.

sawenzel avatar sawenzel commented on July 29, 2024

It isn't. This is filtering on a namespace (which might be a wrong assumption that everything we do is already in a namespace). My intention is also more to have some global service function that filters if the file being parsed is part of the correct repository. This function can than be reused in all the checks.

from o2codechecker.

sawenzel avatar sawenzel commented on July 29, 2024

Seems like we could use
a) clang matchers for this

Matcher<Decl> | isExpansionInFileMatching | std::string RegExp
Matcher<Decl> | isExpansionInMainFile

b) query the filename from the source location and the source manager with SourceManager::getFilename(sourceLocation)

from o2codechecker.

ktf avatar ktf commented on July 29, 2024

Yes, that sounds reasonable. We should make sure it's done at the right point in the matcher, to avoid one regex per node it attempts to match.

from o2codechecker.

sawenzel avatar sawenzel commented on July 29, 2024

Solved via configuration passed in a .clang-tidy file:

for example:

CheckOptions:
+  - key: CheckPathRegex
+    value: '.*/O2/.*'

from o2codechecker.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.