alexleigh / pve-mods Goto Github PK

I applied manually all the patches and included all the sensors that I can get via sensors -j.

The "bar visual" works, however, instead of something like:
CPU temp 39ºC (crit: 100ºC)
I see:
CPU temp NaN%

It looks like the calculation for the bar length size is done correctly, but not for the values display?

Or I'm missing something ?

Tks!

This is for example my CPU:

"coretemp-isa-0000":{
"Adapter": "ISA adapter",
"Package id 0":{
"temp1_input": 42.000,
"temp1_max": 100.000,
"temp1_crit": 100.000,
"temp1_crit_alarm": 0.000
},

which seems to be the default as per the patch files, so I didn't changed anything there.

so Nodes.pm is
cputemp => {
jsonpath => ['coretemp-isa-0000', 'Package id 0'],
valkey => 'temp1_input',
critkey => 'temp1_crit',
},

and I also kept pvemanagerlib.js:

    {
        itemId: 'cputemp',
        iconCls: 'fa fa-fw fa-thermometer-half',
        title: gettext('CPU temp'),
        valueField: 'cputemp',
        maxField: 'cputemp',
        renderer: Proxmox.Utils.render_node_temp,
    },

Would be great!

I followed the tutorial step by step by injecting the files except for the mobile part, but I have no display of temperatures.

Yet the values are present:

Can you briefly list the command line

Hi alexleigh,
thanks for your great work.
Are you planning a version for the recent version of proxmox-widget-toolkit 3.7.0?
A assume using one of your current version is not recommended... :)
Matthias

Hello @alexleigh,
would you be so kind and help me find where is the problem?

I have manually modified all files except pvemanager-mobile.js and after pveproxy restart I cannot reach the GUI.
I figured the cause is return function of render_node_temp in proxmoxlib.js. When I comment this return the GUI is OK.
I am running currently on proxmox version 7.4-15.

Do you have any idea?

I'm assuming from a brief review that this changes doesn't include email alerts as the pvestatd that I think is involved in those processes. I may be very wrong and asking for clarification if I am missing something.

This is exactly what I was looking to find when I started looking around at lm-sensor and thinking maybe a cronjob that emails me. This is much nicer.