alexisthual / fugw Goto Github PK

          I agree, most functions in `solvers/utils.py` are not meant to be public (because they are called through `fugw.mappings` instances, which themselves call `fugw.solvers` instances).

    from fugw.solvers import FUGWSolver
    
    torch.manual_seed(1)
    torch.backends.cudnn.benchmark = True

    nits_bcd = 100
    eval_bcd = 2        
    Ds_normalized = Ds / Ds.max()
    Dt_normalized = Dt / Dt.max()
    F_normalized = c_z / c_z.max()

    fugw = FUGWSolver(
        nits_bcd=nits_bcd,
        nits_uot=1000,
        tol_bcd=1e-7,
        tol_uot=1e-7,
        tol_loss=1e-5,
        eval_bcd=eval_bcd,
        eval_uot=10,
        ibpp_eps_base=1e5,
    )

    divergence="kl"
    
    reg_mode="independent"
    
    solver="sinkhorn"
    
    res = fugw.solve(
        alpha=alpha,
        rho_s=rho_s,
        rho_t=rho_t,
        eps=eps,
        reg_mode=reg_mode,
        divergence=divergence,
        F=F_normalized,
        Ds=Ds_normalized,
        Dt=Dt_normalized,
        init_plan=None,
        solver=solver,
        callback_bcd=None,
        verbose=False,
    )
    
    Why would I get coupling having nan?  In what cases would this happen easily?

  File "/data/parietal/store3/work/pbarbara/fugw/src/fugw/solvers/dense.py", line 425, in solve
    current_loss = compute_fugw_loss(pi, gamma)
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/data/parietal/store3/work/pbarbara/fugw/src/fugw/solvers/dense.py", line 166, in fugw_loss
    "gromov_wasserstein": loss_gromov_wasserstein.item(),
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'item'

          Indeed, these functions are not tested yet. Would be an important addition to make in a follow-up PR.

# Store variables of interest in model
self.pi = res["pi"].detach().cpu()

bertrandthirion@ptb-11107357:~/mygit/fugw$ pip install -e .
Defaulting to user installation because normal site-packages is not writeable
Obtaining file:///home/bertrandthirion/mygit/fugw
  Installing build dependencies ... done
  Checking if build backend supports build_editable ... done
ERROR: Project file:///home/bertrandthirion/mygit/fugw has a 'pyproject.toml' and its build backend is missing the 'build_editable' hook. Since it does not have a 'setup.py' nor a 'setup.cfg', it cannot be installed in editable mode. Consider using a build backend that supports PEP 660.

          I agree, this concatenation of parameters is difficult to understand. It is somewhat consistent across solvers, but I think we should flatten these variables. Once again, I think this would fit more naturally in a follow-up PR.