Git Product home page Git Product logo

routex.js's Issues

Return a function directly instead of an object

Description
It's not a bug. I've found a way to use the link function in a simpler way. The createRouteLinks function returns an object with only one function inside and I think this can be changed.

Describe alternatives you've considered
Return a function instead of an object, to simplify the usage. ⚠️ It will break the library API.

Related code:

routex.js/src/client.js

Lines 60 to 85 in 192e401

function createRouteLinks(routeDefinitions) {
const composedRoutes = composeRoutes(routeDefinitions);
return {
link({ route: routeName, params = {} }) {
if (!routeName) {
throw new Error(`Function link() should have a route name`);
}
let foundRoute = findRouteByName(composedRoutes, routeName);
if (!foundRoute) {
throw new Error(
`Route name "${routeName}" is not defined in your route definitions`
);
}
const { as, href } = foundRoute.getLinkProps(params);
return {
as,
href
};
}
};
}

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.