Git Product home page Git Product logo

Comments (6)

huangjunwen avatar huangjunwen commented on May 24, 2024 1

Suggestion: the context key here should not use a string

// at Manager.Use
ctx := context.WithValue(r.Context(), m.opts.name, session)
//                                    ^^^^^^^^^^^^

As said in the document of WithValue:

...
// The provided key must be comparable and should not be of type
// string or any other built-in type to avoid collisions between
// packages using context.

A non public custom int type can be used instead: assigning each Manager a unique int id as the context key. Also using int as key maybe a little faster than strings.

from scs.

alexedwards avatar alexedwards commented on May 24, 2024

Yes, I think it should be possible to support multiple sessions. I'll try to add it in the the next major version release.

from scs.

alexedwards avatar alexedwards commented on May 24, 2024

Note to self: multiple session managers will need unique names for their session cookies and request context. I need to add a manager.Name() option, and check that that the name is unique at runtime.

from scs.

alexedwards avatar alexedwards commented on May 24, 2024

This is now supported in v1.1.0. When creating multiple session managers, you need to set a unique name for each via the Name() method. Usage looks like this:

package main

import (
	"io"
	"net/http"

	"github.com/alexedwards/scs"
)

var sessionManager1 *scs.Manager
var sessionManager2 *scs.Manager

func main() {

	sessionManager1 = scs.NewCookieManager("secret")
	sessionManager1.Name("foo.session")

	sessionManager2 = scs.NewCookieManager("secret")
	sessionManager2.Name("bar.session")

	mux := http.NewServeMux()
	mux.HandleFunc("/put", putHandler)
	mux.HandleFunc("/get", getHandler)

	http.ListenAndServe(":4000", sessionManager1.Use(sessionManager2.Use(mux)))
}

func putHandler(w http.ResponseWriter, r *http.Request) {
	session1 := sessionManager1.Load(r)
	err := session1.PutString(w, "message", "Hello world 1")
	if err != nil {
		http.Error(w, err.Error(), 500)
	}

	session2 := sessionManager2.Load(r)
	err = session2.PutString(w, "message", "Hello world 2")
	if err != nil {
		http.Error(w, err.Error(), 500)
	}
}

func getHandler(w http.ResponseWriter, r *http.Request) {
	session1 := sessionManager1.Load(r)
	message, err := session1.GetString("message")
	if err != nil {
		http.Error(w, err.Error(), 500)
	}
	io.WriteString(w, message)

	session2 := sessionManager2.Load(r)
	message2, err := session2.GetString("message")
	if err != nil {
		http.Error(w, err.Error(), 500)
	}

	io.WriteString(w, message2)
}

from scs.

huangjunwen avatar huangjunwen commented on May 24, 2024

Thank you very much!

from scs.

alexedwards avatar alexedwards commented on May 24, 2024

@huangjunwen Thanks for the heads up. I've made the context key an unexported sessionName type, which should do the trick of avoiding naming collisions with other packages : 254d989

from scs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.