Git Product home page Git Product logo

Comments (3)

alexedwards avatar alexedwards commented on July 3, 2024 1

I don't think we should change the behavior of GobCodec, I think it's important for it to always return an error if one is encountered.

If you want to ignore the error in specific scenarios, then I believe the right way to do this is to implement your own custom GobCodec type, just like you have with TryGobCodec. Although I'd suggest that you check for a specific expected error and choose to ignore it, rather than just ignoring all errors completely.

from scs.

d2ro avatar d2ro commented on July 3, 2024

Thank you very much for your reply. I absolutely agree with you that an error should always be returned if one is encountered.

I still see the risk that a developer might unwittingly modify the gob serialization format of a custom data type which is stored in a session. That would result in visitors getting internal server errors if their session still holds data in the old serialization format.

A custom ErrorFunc which clears the session (if the error is a gob error) is probably a better solution for this.

from scs.

alexedwards avatar alexedwards commented on July 3, 2024

A custom ErrorFunc which clears the session (if the error is a gob error) is probably a better solution for this.

Good idea, I think that could be a nice approach to this.

from scs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.