Comments (3)
I don't think we should change the behavior of GobCodec
, I think it's important for it to always return an error if one is encountered.
If you want to ignore the error in specific scenarios, then I believe the right way to do this is to implement your own custom GobCodec
type, just like you have with TryGobCodec
. Although I'd suggest that you check for a specific expected error and choose to ignore it, rather than just ignoring all errors completely.
from scs.
Thank you very much for your reply. I absolutely agree with you that an error should always be returned if one is encountered.
I still see the risk that a developer might unwittingly modify the gob serialization format of a custom data type which is stored in a session. That would result in visitors getting internal server errors if their session still holds data in the old serialization format.
A custom ErrorFunc
which clears the session (if the error is a gob error) is probably a better solution for this.
from scs.
A custom ErrorFunc which clears the session (if the error is a gob error) is probably a better solution for this.
Good idea, I think that could be a nice approach to this.
from scs.
Related Issues (20)
- How to recover from corrupt session data? (or how to Destroy without loading the session) HOT 2
- Fails using ListenAndServeTLS HOT 1
- Sqlite3store error constraint failed: NOT NULL constraint failed: sessions.expiry (1299) HOT 4
- manage all session HOT 1
- Redis example is using a different Redis library HOT 8
- Custom names for sessions tables HOT 3
- support partitioned CHIPS cookies HOT 2
- pgxstore expects a *pgxpool.Pool instead of a *sql.DB HOT 5
- Flush / streaming HOT 2
- *scs.sessionResponseWriter does not implement http.Hijacker HOT 3
- Support Turso and libsql HOT 2
- Session getting added to DB, but not to cookie, when set to SameSiteNone, but works in SameSiteLax HOT 2
- Sign session ids/tokens HOT 5
- 2.7.0 breaks websocket compatibility HOT 2
- NATS Jetstream and session replication might be of interest HOT 3
- Submodules not being released with tags HOT 1
- Usage with TursoDB HOT 1
- sqlite3 store with custom table name
- Gob register custom struct HOT 2
- [interest check for new store] sqlite3 store using CGO-less modernc.org/sqlite
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scs.