alexanderschnitzler / templavoila Goto Github PK

Actual behaviour

When i delete five content elements from any column i will receive an AJAX error, because an element could not be deleted

Expected behaviour

It should not matter how many elements i delete, nor how fast these actions take place. Subsequent deletions should be handled

Steps to reproduce the behaviour

Create some content elements. like 3-5 headlines. Delete them in the page modul by clicking on the trash bin.

Actual behaviour

I can not remove the marked from the Form configuration, therefore i get an Exception in the Backend "The way registering a wizard in TCA has changed in 6.2 and was removed in CMS 7."

Expected behaviour

I remove the whole element from the configuration and i click update or safe the whole thing, then the element should not appear again

Steps to reproduce the behaviour

• Add XML to the Form configuration of any element
• try to delete the just added element
• click on update
• the element appears again

Current workaround

I can make use of the ArrayUtility::mergeRecursiveWithOverrule UnsetFeature, if i do not remove <wizards type="array">, but change the element to <wizards>__UNSET</wizards> which removes the element when the new values overrule the previous ones.

Where should you look

Definitively in \Schnitzler\Templavoila\Controller\Backend\AdministrationModule\ElementController::updateDataStructure, where $inDS overrules $dataStructure. $inDS probably always contains the whole TCEforms array, because it is sent when updating the form, so unsetting keys in $dataStructure[..]['config'] that do not exist in $inDS[..]['config'] should be a possible solution.

Actual behaviour

When I leave the <title> tags sections and containers within the <tx_templavoila> tag, as the wizzard in "Modify DS/TO" implements it, they are not shown in the edit forms. When I move them one level up beneath the <tx_templavoila> tag (as suggested in the migration docs), they are shown in the edit forms, but not in the "Modify DS/TO" wizzard anymore.

Expected behaviour

I would expect to have the titles of sections and containers shown in edit forms as well as th the "Modify DS/TO" wizzard.

Steps to reproduce the behaviour

• create a aection and a container in "Modify DS/TO" wizzard.
• test their form and see that they don't show the titles
• move the <title> tags one level up beneath the <tx_templavoila> tag in the XML-DS
• test their form and see that they show the titles
• open the FCE in the "Modify DS/TO" wizzard and see that the tiles vanished

Actual behaviour

After installing tv 7.6.2 and running the Upgrade Wizard, i get the following error when opening a page or a tv ce in the backend.

#1440685208: Broken data structure on field name tx_templavoila_flex. section without type or vice versa is not allowed

In the frontend everything works fine.

Actual behaviour

The wizard for new link-elements sets <script>browse_links.php?mode=wizard&act=file</script> inside TCEForms->config->wizards->link. This is the old behaviour and leads to an exception, when one edits such a content element:

The way registering a wizard in TCA has changed in 6.2 and was removed in CMS 7. Please set module[name]=module_name instead of using script=path/to/script.php in your TCA.

Expected behaviour

According to the Exception Info, the following code snipped must be used. So instead of

<script>browse_links.php?mode=wizard&act=file</script>

use this:

<module type="array">
  <name>wizard_element_browser</name>
  <urlParameters type="array">
    <mode>wizard</mode>
    <act>url</act>
  </urlParameters>
</module>

This change should also be listed with the other breaking changes, as all old datastructures containing link fields must be updated manually.

Steps to reproduce the behaviour

• I have datastructures containing fields of type link (or I create a new one)
• I create new content with this element
• I get the mentiones exception

We made a script that takes TYPO3 4.x TV datastructures and converts them into 7.6-compatible ones. We used it to fix 700 DS automatically with it.

Maybe you want to link it in the README or the docs. It's available at https://github.com/mogic-le/templavoila-76-fixer

Existing FCE or template icons (png or gif) are displayed with the red svg not found icon.

In the TV template object It is not possible to upload svg files, only png or gif

Actual behaviour

When a FCE is opened in the backend, this error message is shown:

Missing "renderType" in TCA of field "[tt_content][tx_templavoila_flex]".

For other FCE I got the message:

Broken data structure on field name tx_templavoila_flex. section without type or vice versa is not allowed

All FCEs worked well in TYPO3 6.2 with templavola 1.9.2

No problems in the frontend. The output works well, but it is not possible to edit any FCE

Cheers
Roland

Actual behaviour

I created a Backend Template and set one mapping's eType (Column "Content") to "Page - Content Element" (ce) and another (Column "Slider") to TypoScriptObject. Rendering the column "Content" is done via the default template, but the column "Slider", which was rendered in earlier versions of TV (1.9.2) won't get rendered in the Page Module anymore when viewing the page's content.

Expected behaviour

Instead of not showing up i expect the column to be rendered as it had functioned earlyier

Steps to reproduce the behaviour

See "Actual behaviour". Anyway, the place where the mapped column should be taken into account is \Schnitzler\Templavoila\Service\ApiService::getContentTree_element@1529 ff which only passes sheet elements with $fieldData['TCEforms'] set, but TypoScriptObjectPath lacks these keys. Simply adding an OR $fieldData['tx_templavoila']['eType'] === 'TypoScriptObject' results in the column beeing passed to the template properly (there are missing some details like width, but it's shown at least).

Actual and expected behaviour

The list of Template Files in the TemplaVoilà Control Center is completely broken in my installation:

1. All filenames are cropped (or missing completely), also the underlying links point to those cropped pathts, like https://my-domain.tld/ain.tld.de/tv_fce_dummy.html instead of https://my-domain.tld/fileadmin/templates_my-domain.tld.de/tv_fce_dummy.html.

2. The "Create new DS/TO" link is broken. In my installation it points to https://my-domain.tld/cm1/index.php?id=55&file=fileadmin/templates_my-domain.tld/tv_fce_dummy.html&mapElPath=[ROOT] which directs me to a 404. In older installations this link pointed to the following address, which doesn't work here either: https://my-domain.tld/typo3conf/ext/templavoila/cm1/index.php?id=55&file=fileadmin/templates_my-domain.tld/tv_fce_dummy.html&mapElPath=[ROOT]

Steps to reproduce the behaviour

I'm not sure if this can be reproduced on other systems, since this is the first installation, I migrated.

Edit: The link in the context menu of files in the file manager are correct and look like:
https://my-domain.tld/typo3/index.php?route=/templavoila/admininstration/element&token=TOKEN&id=0&file=/var/www/my-domain.tld/web/fileadmin/templates_my-domain.tld/tv_fce_dummy.html&dataStructureUid=0&templateObjectUid=0&returnUrl=/typo3/index.php/M=file_FilelistList&moduleToken=TOKEN&id=1%3A%2Ftemplates_my-domain.tld%2F

Actual and expected behaviour

I have a quice compex FCE with nested sections. The outer section holds the link categories of a linklist, the inner section the links. The XML created by TemplaVoilà looks like this (I only implemented the needed fields to better reproduce this):

example of nested sections.txt

I only fixed the <script> of the link field (as mentioned in #2 ) and the <title> and <type> tags of section and containers as described in the breaking changes documentation, so that they are shown in the form. Btw: the xml created by Templavoilà should put the <title> tags of sections and containers to the correct place outside of the <tx_templavoila> tag.

When I create a new content element with this FCE, I can add link categories and within them also links. When I save this content-element, the data is correctly stored in the database and shown in the rendered frontend-output. So far, all works as expected.

But when I edit this content element again, the links are gone. The categories are still there and I can also add new links, but when I save them, they are added to the still existing but invisible other links and also not shown in the form.

Steps to reproduce the behaviour

• create a FCE with a section inside another section (you can use the provided XML)
• create content with this FCE filling the nesting with test data
• save and edit it again: the inner elements are not editable nor visible at all, but the content is still there, as you ca see in the preview.